DevHeads.net

Review Request 122534: [konq-plugins] fsview: Add missing include(ECMMarkAsTest)

Review request for KDE Base Apps.

Repository: kde-baseapps

Description
[konq-plugins] fsview: Add missing include(ECMMarkAsTest)

Diffs
konq-plugins/fsview/tests/CMakeLists.txt 4ee03006999dfb62c25a36bb643f92c3078697b6

Diff: <a href="https://git.reviewboard.kde.org/r/122534/diff/" title="https://git.reviewboard.kde.org/r/122534/diff/">https://git.reviewboard.kde.org/r/122534/diff/</a>

Testing

Thanks,

Andreas Sturmlechner

Comments

Re: Review Request 122534: [konq-plugins] fsview: Add missing in

By Andreas Sturmlechner at 02/11/2015 - 18:52

(Updated Feb. 11, 2015, 11:52 p.m.)

Review request for KDE Base Apps.

Changes
Moved the include up into konq-plugins/CMakeLists.txt

Repository: kde-baseapps

Description (updated)
[konq-plugins] fsview: Add missing include(ECMMarkAsTest)

Diffs (updated)
konq-plugins/CMakeLists.txt 1b70313929a76175167e7fbc6680ee4ff8fc7026

Diff: <a href="https://git.reviewboard.kde.org/r/122534/diff/" title="https://git.reviewboard.kde.org/r/122534/diff/">https://git.reviewboard.kde.org/r/122534/diff/</a>

Testing

Thanks,

Andreas Sturmlechner

Re: Review Request 122534: [konq-plugins] fsview: Add missing in

By Aleix Pol at 02/12/2015 - 06:58

Ship it!

Ship It!

- Aleix Pol Gonzalez

On Feb. 12, 2015, 12:52 a.m., Andreas Sturmlechner wrote:

Re: Review Request 122534: [konq-plugins] fsview: Add missing in

By Kevin Funk at 02/11/2015 - 18:34

I'd move that line to the top CMakeLists.txt.

And remove the duplicate ones in other CMakeLists.txt files.

- Kevin Funk

On Feb. 11, 2015, 9:43 p.m., Andreas Sturmlechner wrote: