DevHeads.net

Review Request 125068: Make Format Painter work in KRichTextWidget

Review request for kdelibs.

Bugs: 221947
<a href="http://bugs.kde.org/show_bug.cgi?id=221947" title="http://bugs.kde.org/show_bug.cgi?id=221947">http://bugs.kde.org/show_bug.cgi?id=221947</a>

Repository: kdelibs

Description
This patch, originally from Anders Lund back in 2010, fixes the problem with the Format Painter changes not taking effect.

Diffs
kdeui/widgets/krichtextwidget.cpp 36ca232

Diff: <a href="https://git.reviewboard.kde.org/r/125068/diff/" title="https://git.reviewboard.kde.org/r/125068/diff/">https://git.reviewboard.kde.org/r/125068/diff/</a>

Testing
Tried it. Format Painter function in KJots works now, so fixes bug 221947

Thanks,

Allen Winter

Comments

Re: Review Request 125068: Make Format Painter work in KRichText

By Allen Winter at 09/08/2015 - 15:07

(Updated Sept. 8, 2015, 7:07 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs.

Changes
Submitted with commit 51da90df9eafaeefe4b2a4a24be3af2ae18df2f8 by Allen Winter to branch KDE/4.14.

Bugs: 221947
<a href="http://bugs.kde.org/show_bug.cgi?id=221947" title="http://bugs.kde.org/show_bug.cgi?id=221947">http://bugs.kde.org/show_bug.cgi?id=221947</a>

Repository: kdelibs

Description
This patch, originally from Anders Lund back in 2010, fixes the problem with the Format Painter changes not taking effect.

Diffs
kdeui/widgets/krichtextwidget.cpp 36ca232

Diff: <a href="https://git.reviewboard.kde.org/r/125068/diff/" title="https://git.reviewboard.kde.org/r/125068/diff/">https://git.reviewboard.kde.org/r/125068/diff/</a>

Testing
Tried it. Format Painter function in KJots works now, so fixes bug 221947

Thanks,

Allen Winter

Re: Review Request 125068: Make Format Painter work in KRichText

By Albert Astals Cid at 09/07/2015 - 16:12

Ship it!

Ship It!

- Albert Astals Cid

On set. 5, 2015, 11:39 p.m., Allen Winter wrote:

Re: Review Request 125068: Make Format Painter work in KRichText

By Luigi Toscano at 09/07/2015 - 16:22

Is the fix relevant for to the ktextwidgets framework as well?

- Luigi

On Set. 6, 2015, 1:39 a.m., Allen Winter wrote: