DevHeads.net

Review Request 128663: Proofread + update Konqueror docbook chapters up to bookmarks

Review request for Documentation, KDE Base Apps and David Faure.

Repository: kde-baseapps

Description
proofread + update
remove entity kappname + package, no longer used
bump date + releaseinfo
remove kde sc
remove commented lines
replace some keys with entities (up, down, left, right etc.)
replace info about webshortcuts + useragent with links to systemsettings modules
replace kde ftp with l10n ftp (tosky: ok?)
comment sect1 portnumbers, is this still usefull?

new screenshots, not uploaded so far, want me to do that?

Diffs
doc/konqueror/index.docbook a9e40ad

Diff: <a href="https://git.reviewboard.kde.org/r/128663/diff/" title="https://git.reviewboard.kde.org/r/128663/diff/">https://git.reviewboard.kde.org/r/128663/diff/</a>

Testing
passes checkXML5

Thanks,

Burkhard Lück

Comments

Re: Review Request 128663: Proofread + update Konqueror docbook

By =?utf-8?q?Burkh... at 08/12/2016 - 16:13

(Updated Aug. 12, 2016, 8:13 nachm.)

Review request for Documentation, KDE Base Apps and David Faure.

Changes
use more entities defined in kdoctools, improve markup

Repository: kde-baseapps

Description
proofread + update
remove entity kappname + package, no longer used
bump date + releaseinfo
remove kde sc
remove commented lines
replace some keys with entities (up, down, left, right etc.)
replace info about webshortcuts + useragent with links to systemsettings modules
replace kde ftp with l10n ftp (tosky: ok?)
comment sect1 portnumbers, is this still usefull?

new screenshots, not uploaded so far, want me to do that?

Diffs (updated)
doc/konqueror/index.docbook a9e40ad

Diff: <a href="https://git.reviewboard.kde.org/r/128663/diff/" title="https://git.reviewboard.kde.org/r/128663/diff/">https://git.reviewboard.kde.org/r/128663/diff/</a>

Testing
passes checkXML5

Thanks,

Burkhard Lück

Re: Review Request 128663: Proofread + update Konqueror docbook

By =?utf-8?q?Burkh... at 08/13/2016 - 15:03

(Updated Aug. 13, 2016, 7:03 nachm.)

Review request for Documentation, KDE Base Apps and David Faure.

Changes
adress David's comments, thanks for review

Repository: kde-baseapps

Description
proofread + update
remove entity kappname + package, no longer used
bump date + releaseinfo
remove kde sc
remove commented lines
replace some keys with entities (up, down, left, right etc.)
replace info about webshortcuts + useragent with links to systemsettings modules
replace kde ftp with l10n ftp (tosky: ok?)
comment sect1 portnumbers, is this still usefull?

new screenshots, not uploaded so far, want me to do that?

Diffs (updated)
doc/konqueror/index.docbook a9e40ad

Diff: <a href="https://git.reviewboard.kde.org/r/128663/diff/" title="https://git.reviewboard.kde.org/r/128663/diff/">https://git.reviewboard.kde.org/r/128663/diff/</a>

Testing
passes checkXML5

Thanks,

Burkhard Lück

Re: Review Request 128663: Proofread + update Konqueror docbook

By =?utf-8?q?Burkh... at 08/14/2016 - 15:09

(Updated Aug. 14, 2016, 7:09 p.m.)

Status
This change has been marked as submitted.

Review request for Documentation, KDE Base Apps and David Faure.

Changes
Submitted with commit 146e958551d39706298fc010db8323fa43e71a5e by Burkhard Lück to branch master.

Repository: kde-baseapps

Description
proofread + update
remove entity kappname + package, no longer used
bump date + releaseinfo
remove kde sc
remove commented lines
replace some keys with entities (up, down, left, right etc.)
replace info about webshortcuts + useragent with links to systemsettings modules
replace kde ftp with l10n ftp (tosky: ok?)
comment sect1 portnumbers, is this still usefull?

new screenshots, not uploaded so far, want me to do that?

Diffs
doc/konqueror/index.docbook a9e40ad

Diff: <a href="https://git.reviewboard.kde.org/r/128663/diff/" title="https://git.reviewboard.kde.org/r/128663/diff/">https://git.reviewboard.kde.org/r/128663/diff/</a>

Testing
passes checkXML5

Thanks,

Burkhard Lück

Re: Review Request 128663: Proofread + update Konqueror docbook

By David Faure at 08/14/2016 - 04:44

Fix it, then Ship it!

doc/konqueror/index.docbook (line 519)
<https://git.reviewboard.kde.org/r/128663/#comment66275>

Err, OK, FIXME was in fact clearer ;-)

- David Faure

On Aug. 13, 2016, 7:03 p.m., Burkhard Lück wrote:

Re: Review Request 128663: Proofread + update Konqueror docbook

By David Faure at 08/13/2016 - 08:34

doc/konqueror/index.docbook (line 71)
<https://git.reviewboard.kde.org/r/128663/#comment66267>

manger -> manager, while at it ;)

doc/konqueror/index.docbook (line 519)
<https://git.reviewboard.kde.org/r/128663/#comment66268>

This comment sounds like it was updated as of 16.04 (well, contradicted by the FIXME)

doc/konqueror/index.docbook (line 1369)
<https://git.reviewboard.kde.org/r/128663/#comment66269>

Indeed, I wonder if konsolepart got broken.

doc/konqueror/index.docbook (line 1794)
<https://git.reviewboard.kde.org/r/128663/#comment66270>

The paths have changed (no more ~/.kde or $KDEDIR) but yeah, I suppose it's still useful. I wasn't aware of this feature, but if KIO denies you of something you have access to, it sounds worth documenting a solution for it.

doc/konqueror/index.docbook (line 1814)
<https://git.reviewboard.kde.org/r/128663/#comment66271>

(maybe that technical detail, the source file name, is not needed)

- David Faure

On Aug. 12, 2016, 8:13 p.m., Burkhard Lück wrote: