DevHeads.net

Review Request 128910: [kio_trash] Fill in UDS_LOCAL_PATH in UDSEntry

Review request for KDE Runtime, KDE Frameworks and David Faure.

Bugs: 208625, 272249, 329155, and 368104
<a href="https://bugs.kde.org/show_bug.cgi?id=208625" title="https://bugs.kde.org/show_bug.cgi?id=208625">https://bugs.kde.org/show_bug.cgi?id=208625</a>
<a href="https://bugs.kde.org/show_bug.cgi?id=272249" title="https://bugs.kde.org/show_bug.cgi?id=272249">https://bugs.kde.org/show_bug.cgi?id=272249</a>
<a href="https://bugs.kde.org/show_bug.cgi?id=329155" title="https://bugs.kde.org/show_bug.cgi?id=329155">https://bugs.kde.org/show_bug.cgi?id=329155</a>
<a href="https://bugs.kde.org/show_bug.cgi?id=368104" title="https://bugs.kde.org/show_bug.cgi?id=368104">https://bugs.kde.org/show_bug.cgi?id=368104</a>

Repository: kio

Description
Not doing so results in PreviewJob assuming the files/folders are remote and copying them to /tmp when generating previews.
This is especially annoying and dangerous if there are large folders in the trash.

KDE4's kio_trash in kde-runtime has the same problem, as the code is basically the same, the same patch fixes it too.

Diffs
src/ioslaves/trash/kio_trash.cpp 3810941

Diff: <a href="https://git.reviewboard.kde.org/r/128910/diff/" title="https://git.reviewboard.kde.org/r/128910/diff/">https://git.reviewboard.kde.org/r/128910/diff/</a>

Testing
Trash some files/folders, open dolphin, navigate to trash:/, and hover over them.
Previews are still generated (if enabled), and the files/folders are not copied to /tmp any more.

Also tried with files on an USB stick, where a folder .Trash-XXX is used as trash.

Thanks,

Wolfgang Bauer

Comments

Re: Review Request 128910: [kio_trash] Fill in UDS_LOCAL_PATH in

By David Faure at 09/28/2016 - 15:15

I'm very afraid of side effects of this.

For instance, deleting the file will do a direct deletion using the local path, not using kio_trash, and therefore leaving the .trashinfo file lying around (and not updating the total size usage of the trash).

And more such unwanted side effects.

Do we really need previews of folders in the trash? How about we disable that, rather?

- David Faure

On Sept. 14, 2016, 6:02 p.m., Wolfgang Bauer wrote:

Re: Review Request 128910: [kio_trash] Fill in UDS_LOCAL_PATH in

By Wolfgang Bauer at 09/28/2016 - 10:01

Ping?

This can really cause bad problems and should be fixed ASAP IMHO, even if the problems exist since years.

- Wolfgang Bauer

On Sept. 14, 2016, 8:02 nachm., Wolfgang Bauer wrote: