DevHeads.net

Review Request 129423: keditbookmarks: add standard icons and shortcuts to Undo/Redo actions

Review request for KDE Base Apps.

Repository: keditbookmarks

Description
These actions are created by QUndoStack in order that it can manage the action text. However, this means that they do not get the standard KDE action icon or shortcuts set. This change sets those by reference to the appropriate KStandardAction.

Diffs
src/kbookmarkmodel/commandhistory.cpp 53a8931

Diff: <a href="https://git.reviewboard.kde.org/r/129423/diff/" title="https://git.reviewboard.kde.org/r/129423/diff/">https://git.reviewboard.kde.org/r/129423/diff/</a>

Testing
Built keditbookmarks (split repository master version) with this change, observed correct appearance and operation of Undo/Redo actions.

Thanks,

Jonathan Marten

Comments

Re: Review Request 129423: keditbookmarks: add standard icons an

By Jonathan Marten at 11/18/2016 - 08:55

(Updated Nov. 18, 2016, 1:55 p.m.)

Status
This change has been marked as submitted.

Review request for KDE Base Apps.

Changes
Submitted with commit aa247198f16179cf86768cfdeed94e7c557e864c by Jonathan Marten to branch master.

Repository: keditbookmarks

Description
These actions are created by QUndoStack in order that it can manage the action text. However, this means that they do not get the standard KDE action icon or shortcuts set. This change sets those by reference to the appropriate KStandardAction.

Diffs
src/kbookmarkmodel/commandhistory.cpp 53a8931

Diff: <a href="https://git.reviewboard.kde.org/r/129423/diff/" title="https://git.reviewboard.kde.org/r/129423/diff/">https://git.reviewboard.kde.org/r/129423/diff/</a>

Testing
Built keditbookmarks (split repository master version) with this change, observed correct appearance and operation of Undo/Redo actions.

Thanks,

Jonathan Marten

Re: Review Request 129423: keditbookmarks: add standard icons an

By Christoph Feck at 11/18/2016 - 08:45

Ship it!

Ship It!

- Christoph Feck

On Nov. 18, 2016, 10:33 a.m., Jonathan Marten wrote: