DevHeads.net

Review Request 129935: Fix build for GCC 7

Review request for kdelibs.

Repository: kdelibs

Description
This fixes building with GCC 7 which fails with
"ISO C++ forbids comparison between pointer and integer [-fpermissive]"

Diffs
kdeui/windowmanagement/netwm.cpp 0c8b0a7d455f40327a03c685b7a7ff2beda901e0

Diff: <a href="https://git.reviewboard.kde.org/r/129935/diff/" title="https://git.reviewboard.kde.org/r/129935/diff/">https://git.reviewboard.kde.org/r/129935/diff/</a>

Testing
I checked that building with GCC 7 shows:
/usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp: In member function 'void NETWinInfo::update(const long unsigned int*)':
/usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp:4371:48: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
p->blockCompositing = (data_ret != None);
^~~~

and the submitted commit fixes this.

Thanks,

Antonio Larrosa Jimenez

Comments

Re: Review Request 129935: Fix build for GCC 7

By Antonio Larrosa... at 02/08/2017 - 15:18

(Updated Feb. 8, 2017, 7:18 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs.

Repository: kdelibs

Description
This fixes building with GCC 7 which fails with
"ISO C++ forbids comparison between pointer and integer [-fpermissive]"

Diffs
kdeui/windowmanagement/netwm.cpp 0c8b0a7d455f40327a03c685b7a7ff2beda901e0

Diff: <a href="https://git.reviewboard.kde.org/r/129935/diff/" title="https://git.reviewboard.kde.org/r/129935/diff/">https://git.reviewboard.kde.org/r/129935/diff/</a>

Testing
I checked that building with GCC 7 shows:
/usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp: In member function 'void NETWinInfo::update(const long unsigned int*)':
/usr/src/packages/BUILD/kdelibs-4.14.28/kdeui/windowmanagement/netwm.cpp:4371:48: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
p->blockCompositing = (data_ret != None);
^~~~

and the submitted commit fixes this.

Thanks,

Antonio Larrosa Jimenez

Re: Review Request 129935: Fix build for GCC 7

By Christoph Feck at 02/08/2017 - 07:57

Ship it!

Ship It!

- Christoph Feck

On Feb. 8, 2017, 10:04 a.m., Antonio Larrosa Jimenez wrote: