DevHeads.net

Review Request: Account for markup in KSqueezedLabel selection

Review request for kdelibs.

Description
This uses a simple regex replace to get rid of tags, not sure if any more complex operations are worth the effort (there is always the "copy all text" menu item).

This addresses bug 303780.
<a href="http://bugs.kde.org/show_bug.cgi?id=303780" title="http://bugs.kde.org/show_bug.cgi?id=303780">http://bugs.kde.org/show_bug.cgi?id=303780</a>

Diffs
kdeui/widgets/ksqueezedtextlabel.cpp 99745d5

Diff: <a href="http://git.reviewboard.kde.org/r/105620/diff/" title="http://git.reviewboard.kde.org/r/105620/diff/">http://git.reviewboard.kde.org/r/105620/diff/</a>

Testing
I tested with the steps from the bug report.

Thanks,

Christoph Feck

Comments

Re: Review Request: Account for markup in KSqueezedLabel selecti

By Commit Hook at 07/21/2012 - 08:31

This review has been submitted with commit 013376e9a962984e42233a9460d52792d39d05cd by Christoph Feck to branch KDE/4.9.

- Commit Hook

On July 19, 2012, 1:20 p.m., Christoph Feck wrote:

Re: Review Request: Account for markup in KSqueezedLabel selecti

By David Faure at 07/19/2012 - 12:42

Ship it!

Good enough for 4.x (the "fully correct" way would involve creating and setting up our own QTextDocument, not worth it here).

This is however a very good additional reason for having this feature in QLabel itself, in Qt-5.1.

- David Faure

On July 19, 2012, 1:20 p.m., Christoph Feck wrote: