DevHeads.net

Review Request: Add missing actions to report bug + switch language to Help menu in dolphin whithout menubar

Review request for KDE Base Apps and Peter Penz.

Summary
Using Dolphin in default mode in master /4.7.) whithout menubar the user has no actions to report a bug or switch language. Patch adds this to the Help menu launched from the toolbar button Configure and control Dolphin.

Diffs
dolphin/src/dolphinmainwindow.cpp 198e2da

Diff: <a href="http://git.reviewboard.kde.org/r/101597/diff" title="http://git.reviewboard.kde.org/r/101597/diff">http://git.reviewboard.kde.org/r/101597/diff</a>

Testing

Thanks,

Burkhard

Comments

Re: Review Request: Add missing actions to report bug + switch l

By Peter Penz at 06/12/2011 - 17:49

Ship it!

Thanks for the patch! I completely missed this entry (I rarely report Dolphin bugs this way ;-))...

- Peter

On June 12, 2011, 8:21 p.m., Burkhard Lück wrote:

Re: Review Request: Add missing actions to report bug + switch l

By Peter Penz at 06/13/2011 - 07:21

Thanks for the hint - yes, that would be better. I've added this to my TODO-list - I'm currently busy with some other things but won't forget about this.

- Peter

On June 12, 2011, 8:21 p.m., Burkhard Lück wrote:

Re: Review Request: Add missing actions to report bug + switch l

By Albert Astals Cid at 06/13/2011 - 03:44

I know this is "off topic" for this review request but shouldn't this code be using a KHelpMenu? By doing that you'll avoid missing some entries

- Albert

On June 12, 2011, 8:21 p.m., Burkhard Lück wrote: