DevHeads.net

Review Request: bilinear scaling for khtml/imload

Review request for kdelibs.

Description
Uses bilinear scaling for images. It's a bit prettier, but not much, but should be a reasonable tradeoff for speed.

Diffs
khtml/imload/scaledimageplane.h 35fec21
khtml/imload/scaledimageplane.cpp 4977201

Diff: <a href="http://git.reviewboard.kde.org/r/104743/diff/" title="http://git.reviewboard.kde.org/r/104743/diff/">http://git.reviewboard.kde.org/r/104743/diff/</a>

Testing
ran it against a couple of different images of various sizes.

Screenshots
Before
<a href="http://git.reviewboard.kde.org/r/104743/s/547/" title="http://git.reviewboard.kde.org/r/104743/s/547/">http://git.reviewboard.kde.org/r/104743/s/547/</a>
After
<a href="http://git.reviewboard.kde.org/r/104743/s/548/" title="http://git.reviewboard.kde.org/r/104743/s/548/">http://git.reviewboard.kde.org/r/104743/s/548/</a>

Thanks,

Martin Tobias Holmedahl Sandsmark

Comments

Re: Review Request: bilinear scaling for khtml/imload

By Martin Tobias H... at 04/26/2012 - 14:54

(Updated April 26, 2012, 6:54 p.m.)

Review request for kdelibs.

Changes
merged in the patch that moves the implementation into a separate cpp file.

Description
Uses bilinear scaling for images. It's a bit prettier, but not much, but should be a reasonable tradeoff for speed.

Diffs (updated)
khtml/imload/scaledimageplane.h 35fec21
khtml/imload/scaledimageplane.cpp 4977201

Diff: <a href="http://git.reviewboard.kde.org/r/104743/diff/" title="http://git.reviewboard.kde.org/r/104743/diff/">http://git.reviewboard.kde.org/r/104743/diff/</a>

Testing
ran it against a couple of different images of various sizes.

Screenshots
Before
<a href="http://git.reviewboard.kde.org/r/104743/s/547/" title="http://git.reviewboard.kde.org/r/104743/s/547/">http://git.reviewboard.kde.org/r/104743/s/547/</a>
After
<a href="http://git.reviewboard.kde.org/r/104743/s/548/" title="http://git.reviewboard.kde.org/r/104743/s/548/">http://git.reviewboard.kde.org/r/104743/s/548/</a>

Thanks,

Martin Tobias Holmedahl Sandsmark

Re: Review Request: bilinear scaling for khtml/imload

By Martin Tobias H... at 04/30/2012 - 17:22

(Updated April 30, 2012, 9:22 p.m.)

Review request for kdelibs.

Changes
now just uses nearest neighbour for 8bit indexed images (good enough, unless someone has a better idea).

Description
Uses bilinear scaling for images. It's a bit prettier, but not much, but should be a reasonable tradeoff for speed.

Diffs (updated)
khtml/imload/scaledimageplane.h 35fec21
khtml/imload/scaledimageplane.cpp 4977201

Diff: <a href="http://git.reviewboard.kde.org/r/104743/diff/" title="http://git.reviewboard.kde.org/r/104743/diff/">http://git.reviewboard.kde.org/r/104743/diff/</a>

Testing
ran it against a couple of different images of various sizes.

Screenshots
Before
<a href="http://git.reviewboard.kde.org/r/104743/s/547/" title="http://git.reviewboard.kde.org/r/104743/s/547/">http://git.reviewboard.kde.org/r/104743/s/547/</a>
After
<a href="http://git.reviewboard.kde.org/r/104743/s/548/" title="http://git.reviewboard.kde.org/r/104743/s/548/">http://git.reviewboard.kde.org/r/104743/s/548/</a>

Thanks,

Martin Tobias Holmedahl Sandsmark

Re: Review Request: bilinear scaling for khtml/imload

By Allan Sandfeld ... at 05/01/2012 - 03:49

Ship it!

Ship It!

- Allan Sandfeld Jensen

On April 30, 2012, 9:22 p.m., Martin Tobias Holmedahl Sandsmark wrote:

Re: Review Request: bilinear scaling for khtml/imload

By Allan Sandfeld ... at 04/26/2012 - 17:23

Looks good, but I think you need to disable it or do something very different for 8bit color images.

- Allan Sandfeld Jensen

On April 26, 2012, 6:54 p.m., Martin Tobias Holmedahl Sandsmark wrote: