DevHeads.net

Review Request: Can't switch back to laptop display when external display gets disconnected

Review request for kdelibs and usability.

Summary
I already posted this patch here:
<a href="https://bugs.kde.org/show_bug.cgi?id=265955" title="https://bugs.kde.org/show_bug.cgi?id=265955">https://bugs.kde.org/show_bug.cgi?id=265955</a>

This is a patch to the kded_randrmonitor service that solves the below
mentioned problem.
If only one output is connected and the user tries to switch the display it
makes sure the connected output gets activated and deactivates all disconnected
output afterwards.

Reproducible: Always

Steps to Reproduce:
1. Connect an external display to your laptop and use your latop's hotkey (e.g.
Fn+F6) to active it and deactivate your laptop's display.
2. Disconnect the external display
3. Try to switch back to internal display with your keyboard

Actual Results:
Nothing happens

This addresses bugs 257642 and 265955.
<a href="https://bugs.kde.org/show_bug.cgi?id=257642" title="https://bugs.kde.org/show_bug.cgi?id=257642">https://bugs.kde.org/show_bug.cgi?id=257642</a>
<a href="https://bugs.kde.org/show_bug.cgi?id=265955" title="https://bugs.kde.org/show_bug.cgi?id=265955">https://bugs.kde.org/show_bug.cgi?id=265955</a>

Diffs
/branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.h 1219928
/branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.cpp 1219928

Diff: <a href="http://svn.reviewboard.kde.org/r/6513/diff" title="http://svn.reviewboard.kde.org/r/6513/diff">http://svn.reviewboard.kde.org/r/6513/diff</a>

Testing

Thanks,

alter_schwede

Comments

Re: Review Request: Can't switch back to laptop display when ext

By alter_schwede at 02/19/2011 - 19:03

(Updated Feb. 20, 2011, 12:03 a.m.)

Review request for kdelibs and usability.

Changes
Using the Solid resumingFromSuspend() dbus signal now.

Summary
I already posted this patch here:
<a href="https://bugs.kde.org/show_bug.cgi?id=265955" title="https://bugs.kde.org/show_bug.cgi?id=265955">https://bugs.kde.org/show_bug.cgi?id=265955</a>

This is a patch to the kded_randrmonitor service that solves the below
mentioned problem.
If only one output is connected and the user tries to switch the display it
makes sure the connected output gets activated and deactivates all disconnected
output afterwards.

Reproducible: Always

Steps to Reproduce:
1. Connect an external display to your laptop and use your latop's hotkey (e.g.
Fn+F6) to active it and deactivate your laptop's display.
2. Disconnect the external display
3. Try to switch back to internal display with your keyboard

Actual Results:
Nothing happens

This addresses bugs 257642 and 265955.
<a href="https://bugs.kde.org/show_bug.cgi?id=257642" title="https://bugs.kde.org/show_bug.cgi?id=257642">https://bugs.kde.org/show_bug.cgi?id=257642</a>
<a href="https://bugs.kde.org/show_bug.cgi?id=265955" title="https://bugs.kde.org/show_bug.cgi?id=265955">https://bugs.kde.org/show_bug.cgi?id=265955</a>

Diffs (updated)
/branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.h 1219928
/branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.cpp 1219928

Diff: <a href="http://svn.reviewboard.kde.org/r/6513/diff" title="http://svn.reviewboard.kde.org/r/6513/diff">http://svn.reviewboard.kde.org/r/6513/diff</a>

Testing

Thanks,

alter_schwede

Re: Review Request: Can't switch back to laptop display when ext

By alter_schwede at 02/19/2011 - 20:48

(Updated Feb. 20, 2011, 1:48 a.m.)

Review request for kdelibs and usability.

Changes
I think it's better to read/understand now.

Summary
I already posted this patch here:
<a href="https://bugs.kde.org/show_bug.cgi?id=265955" title="https://bugs.kde.org/show_bug.cgi?id=265955">https://bugs.kde.org/show_bug.cgi?id=265955</a>

This is a patch to the kded_randrmonitor service that solves the below
mentioned problem.
If only one output is connected and the user tries to switch the display it
makes sure the connected output gets activated and deactivates all disconnected
output afterwards.

Reproducible: Always

Steps to Reproduce:
1. Connect an external display to your laptop and use your latop's hotkey (e.g.
Fn+F6) to active it and deactivate your laptop's display.
2. Disconnect the external display
3. Try to switch back to internal display with your keyboard

Actual Results:
Nothing happens

This addresses bugs 257642 and 265955.
<a href="https://bugs.kde.org/show_bug.cgi?id=257642" title="https://bugs.kde.org/show_bug.cgi?id=257642">https://bugs.kde.org/show_bug.cgi?id=257642</a>
<a href="https://bugs.kde.org/show_bug.cgi?id=265955" title="https://bugs.kde.org/show_bug.cgi?id=265955">https://bugs.kde.org/show_bug.cgi?id=265955</a>

Diffs (updated)
/branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.h 1221086
/branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.cpp 1221086

Diff: <a href="http://svn.reviewboard.kde.org/r/6513/diff" title="http://svn.reviewboard.kde.org/r/6513/diff">http://svn.reviewboard.kde.org/r/6513/diff</a>

Testing

Thanks,

alter_schwede

Re: Review Request: Can't switch back to laptop display when ext

By alter_schwede at 02/21/2011 - 12:29

(Updated Feb. 21, 2011, 5:29 p.m.)

Review request for kdelibs and usability.

Changes
One more thing that came to my mind: Don't check if the output is already enabled if it's the only one. This will set it to the preferred resolution if it's already active.

Summary
I already posted this patch here:
<a href="https://bugs.kde.org/show_bug.cgi?id=265955" title="https://bugs.kde.org/show_bug.cgi?id=265955">https://bugs.kde.org/show_bug.cgi?id=265955</a>

This is a patch to the kded_randrmonitor service that solves the below
mentioned problem.
If only one output is connected and the user tries to switch the display it
makes sure the connected output gets activated and deactivates all disconnected
output afterwards.

Reproducible: Always

Steps to Reproduce:
1. Connect an external display to your laptop and use your latop's hotkey (e.g.
Fn+F6) to active it and deactivate your laptop's display.
2. Disconnect the external display
3. Try to switch back to internal display with your keyboard

Actual Results:
Nothing happens

This addresses bugs 257642 and 265955.
<a href="https://bugs.kde.org/show_bug.cgi?id=257642" title="https://bugs.kde.org/show_bug.cgi?id=257642">https://bugs.kde.org/show_bug.cgi?id=257642</a>
<a href="https://bugs.kde.org/show_bug.cgi?id=265955" title="https://bugs.kde.org/show_bug.cgi?id=265955">https://bugs.kde.org/show_bug.cgi?id=265955</a>

Diffs (updated)
/branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.h 1221086
/branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.cpp 1221086

Diff: <a href="http://svn.reviewboard.kde.org/r/6513/diff" title="http://svn.reviewboard.kde.org/r/6513/diff">http://svn.reviewboard.kde.org/r/6513/diff</a>

Testing

Thanks,

alter_schwede

Re: Review Request: Can't switch back to laptop display when ext

By =?utf-8?b?THVrw... at 02/20/2011 - 10:51

Looks OK to me

- Lukáš

On Feb. 20, 2011, 1:48 a.m., alter_schwede wrote:

Re: Review Request: Can't switch back to laptop display when ext

By Lamarque Souza at 07/11/2011 - 11:00

Patch submitted. I do not know why but it has not been marked as so. Someone please close this review request.

- Lamarque

On Feb. 21, 2011, 5:29 p.m., alter_schwede wrote:

Re: Review Request: Can't switch back to laptop display when ext

By Lamarque Souza at 07/10/2011 - 19:23

Ok, I will commit this patch then.

- Lamarque

On Feb. 21, 2011, 5:29 p.m., alter_schwede wrote:

Re: Review Request: Can't switch back to laptop display when ext

By Lamarque Souza at 04/08/2011 - 18:18

Can this patch be commited to trunk?

- Lamarque

On Feb. 21, 2011, 5:29 p.m., alter_schwede wrote:

Re: Review Request: Can't switch back to laptop display when ext

By Martin Bednar at 02/18/2011 - 10:42

/branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.cpp
<http://svn.reviewboard.kde.org/r/6513/#comment11048>

rather than a UPower signal, use the Solid resumingFromSuspend() dbus signal.

- Martin

On Feb. 18, 2011, 1:48 a.m., alter_schwede wrote: