DevHeads.net

Review Request: Do not crash when KXMLGUIFactoryPrivate::saveDefaultActionProperties' parameter contains null QActions

Review request for kdelibs and David Faure.

Summary
This patch addresses the crash outlined in bug# 265217. Though a null QAction should not be present in the parameter passed to XMLGUIFactoryPrivate::saveDefaultActionProperties in the first place, the code in that function should be reiliant enough not to crash even such a QAction exists.

This addresses bug 265217.
<a href="http://bugs.kde.org/show_bug.cgi?id=265217" title="http://bugs.kde.org/show_bug.cgi?id=265217">http://bugs.kde.org/show_bug.cgi?id=265217</a>

Diffs
kdeui/xmlgui/kxmlguifactory.cpp 4e6989b

Diff: <a href="http://git.reviewboard.kde.org/r/102419/diff" title="http://git.reviewboard.kde.org/r/102419/diff">http://git.reviewboard.kde.org/r/102419/diff</a>

Testing
Checked to make sure the crash no longer happens with this patch applied.

Thanks,

Dawit

Comments

Re: Review Request: Do not crash when KXMLGUIFactoryPrivate::sav

By Commit Hook at 08/24/2011 - 12:05

This review has been submitted with commit b37cc1c84c923c10a4946b0e261dece34daab00a by Dawit Alemayehu to branch frameworks.

- Commit

On Aug. 24, 2011, 5:27 a.m., Dawit Alemayehu wrote:

Re: Review Request: Do not crash when KXMLGUIFactoryPrivate::sav

By Commit Hook at 08/24/2011 - 12:05

This review has been submitted with commit 35f5e5d814a1f489e9ed52ac9b890826d888b123 by Dawit Alemayehu to branch KDE/4.7.

- Commit

On Aug. 24, 2011, 5:27 a.m., Dawit Alemayehu wrote:

Re: Review Request: Do not crash when KXMLGUIFactoryPrivate::sav

By David Faure at 08/24/2011 - 08:41

Ship it!

Sure, but finding where the null pointer comes from (in konqueror's code apparently) would be a good idea too :-)

- David

On Aug. 24, 2011, 5:27 a.m., Dawit Alemayehu wrote: