DevHeads.net

Review Request: Do not leave dangling pointers in KToolbar when xml clients die

By Albert Astals Cid at 07/01/2012 - 05:11

Review request for kdelibs and David Faure.

Description
If we add xmlclients to ktoolbar when plugging them in we should remove them when unplugging them

This addresses bug 296622.
<a href="http://bugs.kde.org/show_bug.cgi?id=296622" title="http://bugs.kde.org/show_bug.cgi?id=296622">http://bugs.kde.org/show_bug.cgi?id=296622</a>

Diffs
kdeui/widgets/ktoolbar.h c78263f
kdeui/widgets/ktoolbar.cpp c6bd200
kdeui/xmlgui/kxmlguifactory_p.cpp 083ddf5

Diff: <a href="http://git.reviewboard.kde.org/r/105399/diff/" title="http://git.reviewboard.kde.org/r/105399/diff/">http://git.reviewboard.kde.org/r/105399/diff/</a>

Testing
The crash is gone as described in the steps in the bug to reproduce

Thanks,

Albert Astals Cid

Comments

Re: Review Request: Do not leave dangling pointers in KToolbar w

By Commit Hook at 07/17/2012 - 14:21

This review has been submitted with commit 776098aae397b499a95d6855ef16f67eb8546598 by Albert Astals Cid to branch KDE/4.8.

- Commit Hook

On July 1, 2012, 9:11 a.m., Albert Astals Cid wrote:

Re: Review Request: Do not leave dangling pointers in KToolbar w

By Commit Hook at 07/01/2012 - 09:24

This review has been submitted with commit c6b4a45d2281a2b317a789693753544b64ffb59f by Albert Astals Cid to branch KDE/4.9.

- Commit Hook

On July 1, 2012, 9:11 a.m., Albert Astals Cid wrote:

Re: Review Request: Do not leave dangling pointers in KToolbar w

By David Faure at 07/01/2012 - 05:17

Ship it!

Looks good (except for the new trailing whitespaces, see the red boxes on reviewboard)

- David Faure

On July 1, 2012, 9:11 a.m., Albert Astals Cid wrote: