DevHeads.net

Review Request: Do not try to hide the current part's widget when switching views

Review request for KDE Base Apps and David Faure.

Description
The attach patch fixes the issue stated in the aforementioned bug report. More specifically if you split a directory view in Konqueror and attempt to preview a embeded inside of the view that does not have the focus, you get a very weird behavior that randomly affects both sides of the split view. For the description of the problem and how to reproduce it, see the bug report.

The fix was to simply comment out the code that attempt to hide the widget of the current view (inside KonqView::switchView) before switching out the dolphin part (filemanagement) for the part that is going to show the content to be previewed. When this piece of code is removed KonqViewManager::doSetActivePart is not somehow invoked with the current DolphinPart as the part to be set as the active one. Why that happens I do not know. However, after watching what happens when attempting to reproduce BR# 258278, I am tempted to say that this fix might actually resolve several other bug reports where clicking on a file to preview it in Konqueror did not result in the correct outcome. For example, see bug 279937, bug 280364 and bug 282283.

This addresses bugs 258278 and 267215.
<a href="http://bugs.kde.org/show_bug.cgi?id=258278" title="http://bugs.kde.org/show_bug.cgi?id=258278">http://bugs.kde.org/show_bug.cgi?id=258278</a>
<a href="http://bugs.kde.org/show_bug.cgi?id=267215" title="http://bugs.kde.org/show_bug.cgi?id=267215">http://bugs.kde.org/show_bug.cgi?id=267215</a>

Diffs
konqueror/src/konqview.cpp f1e12b9

Diff: <a href="http://git.reviewboard.kde.org/r/103401/diff/diff" title="http://git.reviewboard.kde.org/r/103401/diff/diff">http://git.reviewboard.kde.org/r/103401/diff/diff</a>

Testing

Thanks,

Dawit Alemayehu

Comments

Re: Review Request: Do not try to hide the current part's widget

By Commit Hook at 12/14/2011 - 16:49

This review has been submitted with commit 58b38cdc042a7767d09ee952abeff7016dedd5dc by Dawit Alemayehu to branch master.

- Commit Hook

On Dec. 13, 2011, 7:37 a.m., Dawit Alemayehu wrote: