DevHeads.net

Review Request: Do not use user selected default browser to open XML files

Review request for kdelibs and David Faure.

Description
The attach patch prevents KRun from opening XML files in the user configured default browser. That way clicking on an XML document in Dolphin does not result in the file being open with the default browser.

Technically I am arguing against the position I took in the review that resulted in this change ; so this is my own doing in the first place. See <a href="https://git.reviewboard.kde.org/r/103524/" title="https://git.reviewboard.kde.org/r/103524/">https://git.reviewboard.kde.org/r/103524/</a> for the details.

This addresses bug 291177.
<a href="http://bugs.kde.org/show_bug.cgi?id=291177" title="http://bugs.kde.org/show_bug.cgi?id=291177">http://bugs.kde.org/show_bug.cgi?id=291177</a>

Diffs
kio/kio/krun.cpp 53ab878

Diff: <a href="http://git.reviewboard.kde.org/r/105476/diff/" title="http://git.reviewboard.kde.org/r/105476/diff/">http://git.reviewboard.kde.org/r/105476/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Comments

Re: Review Request: Do not use user selected default browser to

By Commit Hook at 07/08/2012 - 12:17

This review has been submitted with commit d4af904d455c8348d128568f87beb4f74099578e by Dawit Alemayehu to branch KDE/4.9.

- Commit Hook

On July 7, 2012, 7:16 p.m., Dawit Alemayehu wrote:

Re: Review Request: Do not use user selected default browser to

By David Faure at 07/08/2012 - 02:56

kio/kio/krun.cpp
<http://git.reviewboard.kde.org/r/105476/#comment12145>

OK, but add application/xhtml+xml instead, you most probably want that one.

It wasn't there because it's a subclass of application/xml so it was covered already.

- David Faure

On July 7, 2012, 7:16 p.m., Dawit Alemayehu wrote: