DevHeads.net

Review Request: Fix for bug 264444: ksplashx shows garbage when background image does not properly cover entire screen

Review request for KDE Base Apps and KDE Runtime.

Summary
The base splashimage pixmap/qimage is never initialized, so if for some reason the splashscreen doesn't cover the entire screen, you get garbage.

That reason can be a ksplashx theme that does not use multiple monitors on a multi-monitor system, or if it picks a background that is smaller than the current resolution (for example the Horos splash 1280x1024 version appears to be 1278x1024).

This addresses bug 264444.
<a href="http://bugs.kde.org/show_bug.cgi?id=264444" title="http://bugs.kde.org/show_bug.cgi?id=264444">http://bugs.kde.org/show_bug.cgi?id=264444</a>

Diffs
ksplash/ksplashx/splash.cpp d6a992a

Diff: <a href="http://git.reviewboard.kde.org/r/100520/diff" title="http://git.reviewboard.kde.org/r/100520/diff">http://git.reviewboard.kde.org/r/100520/diff</a>

Testing
I tested this by both replacing the background that ksplashx was using with a smaller one, and on two multi-monitor systems (one of which uses a gentoo ksplash screen that only covered one of the monitors).

The splash_image.fill( 0 ) can be changed to another color for debugging purposes, clearly showing the region of the monitor that is not covered by the splashscreen (and where before would be garbage from graphics memory).

Thanks,

Ivo

Comments

Re: Review Request: Fix for bug 264444: ksplashx shows garbage w

By Ivo Anjo at 02/04/2011 - 16:47

(Updated Feb. 4, 2011, 9:47 p.m.)

Review request for KDE Base Apps and KDE Runtime.

Changes
Small cleanups and added screenshot.

Summary (updated)
The background pixmap/qimage is never initialized, so if for some reason the splashscreen doesn't cover the entire screen, you get garbage.

That reason can be a ksplashx theme that does not use multiple monitors on a multi-monitor system, or if it picks a background that is smaller than the current resolution (for example the Horos splash 1280x1024 version appears to be 1278x1024).

This addresses bug 264444.
<a href="http://bugs.kde.org/show_bug.cgi?id=264444" title="http://bugs.kde.org/show_bug.cgi?id=264444">http://bugs.kde.org/show_bug.cgi?id=264444</a>

Diffs
ksplash/ksplashx/splash.cpp d6a992a

Diff: <a href="http://git.reviewboard.kde.org/r/100520/diff" title="http://git.reviewboard.kde.org/r/100520/diff">http://git.reviewboard.kde.org/r/100520/diff</a>

Testing
I tested this by both replacing the background that ksplashx was using with a smaller one, and on two multi-monitor systems (one of which uses a gentoo ksplash screen that only covered one of the monitors).

The splash_image.fill( 0 ) can be changed to another color for debugging purposes, clearly showing the region of the monitor that is not covered by the splashscreen (and where before would be garbage from graphics memory).

Screenshots
Example screenshot when background image does not fully cover the screen, on a dual 1280x1024 machine.
<a href="http://git.reviewboard.kde.org/r/100520/s/70/" title="http://git.reviewboard.kde.org/r/100520/s/70/">http://git.reviewboard.kde.org/r/100520/s/70/</a>

Thanks,

Ivo

Re: Review Request: Fix for bug 264444: ksplashx shows garbage w

By Ivo Anjo at 03/12/2011 - 05:56

(Updated March 12, 2011, 10:56 a.m.)

Review request for KDE Base Apps and KDE Runtime.

Changes
Bumped review request so it gets noticed.

Summary (updated)
*Bump*: Can someone take a look at this? The patch is quite small, and I haven't seen any problems while using it on multiple computers...

The background pixmap/qimage is never initialized, so if for some reason the splashscreen doesn't cover the entire screen, you get garbage.

That reason can be a ksplashx theme that does not use multiple monitors on a multi-monitor system, or if it picks a background that is smaller than the current resolution (for example the Horos splash 1280x1024 version appears to be 1278x1024).

This addresses bug 264444.
<a href="http://bugs.kde.org/show_bug.cgi?id=264444" title="http://bugs.kde.org/show_bug.cgi?id=264444">http://bugs.kde.org/show_bug.cgi?id=264444</a>

Diffs
ksplash/ksplashx/splash.cpp d6a992a

Diff: <a href="http://git.reviewboard.kde.org/r/100520/diff" title="http://git.reviewboard.kde.org/r/100520/diff">http://git.reviewboard.kde.org/r/100520/diff</a>

Testing
I tested this by both replacing the background that ksplashx was using with a smaller one, and on two multi-monitor systems (one of which uses a gentoo ksplash screen that only covered one of the monitors).

The splash_image.fill( 0 ) can be changed to another color for debugging purposes, clearly showing the region of the monitor that is not covered by the splashscreen (and where before would be garbage from graphics memory).

Screenshots
Example screenshot when background image does not fully cover the screen, on a dual 1280x1024 machine.
<a href="http://git.reviewboard.kde.org/r/100520/s/70/" title="http://git.reviewboard.kde.org/r/100520/s/70/">http://git.reviewboard.kde.org/r/100520/s/70/</a>

Thanks,

Ivo