DevHeads.net

Review Request: Fix compilation of Dolphin with future kdelibs, v4.9.2 or higher

Review request for Dolphin and KDE Base Apps.

Description
Since this is not my call to make. The attached patch fixes the compilation of Dolphin with KDE v4.9.2. It is effectively a fix of a prior commit <a href="http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b" title="http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b">http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1...</a> which will not work. See <a href="http://lists.kde.org/?l=kde-core-devel&amp;m=134747823101454&amp;w=2" title="http://lists.kde.org/?l=kde-core-devel&amp;m=134747823101454&amp;w=2">http://lists.kde.org/?l=kde-core-devel&amp;m=134747823101454&amp;w=2</a>.

Diffs
dolphin/src/CMakeLists.txt afc190f
dolphin/src/dolphinpart.h 0895686
dolphin/src/dolphinpart.cpp a7e8bff
dolphin/src/dolphinpart_ext.h PRE-CREATION
dolphin/src/dolphinpart_ext.cpp PRE-CREATION

Diff: <a href="http://git.reviewboard.kde.org/r/106438/diff/" title="http://git.reviewboard.kde.org/r/106438/diff/">http://git.reviewboard.kde.org/r/106438/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Comments

Re: Review Request: Fix compilation of Dolphin with future kdeli

By Allen Winter at 09/15/2012 - 09:51

Ship it!

Builds with master, check
Builds with 4.9, check
thanks

- Allen Winter

On Sept. 13, 2012, 1:08 p.m., Dawit Alemayehu wrote: