DevHeads.net

Review Request: Fix directory navigation in Dolphin::Terminal.

Review request for KDE Base Apps.

Summary
Fix directory navigation in Dolphin::Terminal.

When navigating in Dolphin it attempts to keep any open Terminal (F4)
in sync by changing the directory in the shell. It does this by
sending a "^C; cd $DIRECTORY" however shells under FreeBSD treat "^C"
as a literal string and not SIGINT. Fix this by sending SIGINT to the
shell instead of "^C".

It appears Linux does not exhibit this behaviour.

Patch originally written by David Naylor, from the KDE-FreeBSD team.

Diffs
dolphin/src/panels/terminal/terminalpanel.cpp 61d80cbfa26fb17d0ba403a52f2ab57fbae7b3cc

Diff: <a href="http://git.reviewboard.kde.org/r/101096/diff" title="http://git.reviewboard.kde.org/r/101096/diff">http://git.reviewboard.kde.org/r/101096/diff</a>

Testing
Changing directories with a terminal open now changes the terminal's current directory fine on FreeBSD.

Thanks,

Raphael

Comments

Re: Review Request: Fix directory navigation in Dolphin::Termina

By Commit Hook at 04/12/2011 - 10:12

This review has been submitted with commit 5f78219e18073e475ed1f1865a1a2be1fafd60cf by Raphael Kubo da Costa.

- Commit

On April 12, 2011, 4:37 a.m., Raphael Kubo da Costa wrote:

Re: Review Request: Fix directory navigation in Dolphin::Termina

By Peter Penz at 04/12/2011 - 01:43

Ship it!

Thanks, looks good!

dolphin/src/panels/terminal/terminalpanel.cpp
<http://git.reviewboard.kde.org/r/101096/#comment2249>

Please leave the open/closing braces also when only one statement is used (see <a href="http://techbase.kde.org/Policies/Kdelibs_Coding_Style" title="http://techbase.kde.org/Policies/Kdelibs_Coding_Style">http://techbase.kde.org/Policies/Kdelibs_Coding_Style</a>)

- Peter

On April 12, 2011, 4:37 a.m., Raphael Kubo da Costa wrote: