DevHeads.net

Review Request: fix exports using Q_DECL_EXPORT

Review request for kdelibs, Stephen Kelly, David Faure, and Alexander Neundorf.

Description
This fix is needed for some custom exports on windows. Given there is no KDE_EXPORT anymore, I use Q_DECL_EXPORT for now. See also the discussion on <a href="mailto:kde-frameworks- ... at kde dot org">kde-frameworks- ... at kde dot org</a>.

Diffs
kdecore/localization/ktranscript.cpp 08ebf0e
kdecore/util/kexportplugin.h 775ed48

Diff: <a href="http://git.reviewboard.kde.org/r/105452/diff/" title="http://git.reviewboard.kde.org/r/105452/diff/">http://git.reviewboard.kde.org/r/105452/diff/</a>

Testing
windows only.

Thanks,

Patrick Spendrin

Comments

Re: Review Request 105452: fix exports using Q_DECL_EXPORT

By Patrick Spendrin at 05/29/2013 - 02:09

(Updated May 29, 2013, 7:09 a.m.)

Status
This change has been marked as submitted.

Review request for kdelibs, David Faure, Alexander Neundorf, and Stephen Kelly.

Description
This fix is needed for some custom exports on windows. Given there is no KDE_EXPORT anymore, I use Q_DECL_EXPORT for now. See also the discussion on <a href="mailto:kde-frameworks- ... at kde dot org">kde-frameworks- ... at kde dot org</a>.

Diffs
kdecore/localization/ktranscript.cpp 08ebf0e
kdecore/util/kexportplugin.h 775ed48

Diff: <a href="http://git.reviewboard.kde.org/r/105452/diff/" title="http://git.reviewboard.kde.org/r/105452/diff/">http://git.reviewboard.kde.org/r/105452/diff/</a>

Testing
windows only.

Thanks,

Patrick Spendrin

Re: Review Request 105452: fix exports using Q_DECL_EXPORT

By Albert Astals Cid at 02/08/2013 - 13:23

What's the status on this? Should be discarded? Reworked?

- Albert Astals Cid

On July 5, 2012, 1:09 p.m., Patrick Spendrin wrote:

Re: Review Request 105452: fix exports using Q_DECL_EXPORT

By Patrick Spendrin at 05/29/2013 - 02:09

Ok, steveire fixed this in cmake upstreams.

- Patrick

On July 5, 2012, 1:09 p.m., Patrick Spendrin wrote:

Re: Review Request 105452: fix exports using Q_DECL_EXPORT

By Patrick Spendrin at 02/12/2013 - 17:17

It needs to be reworked, because I doubt that the issue has vanished by not looking at it.

- Patrick

On July 5, 2012, 1:09 p.m., Patrick Spendrin wrote:

Re: Review Request: fix exports using Q_DECL_EXPORT

By Stephen Kelly at 07/05/2012 - 08:40

I disagree. I think the best solution is to have a copy of the cmake generate export header stuff in frameworks and use the new macro in the copy. The copy can be removed when we depend on a later version of CMake.

- Stephen Kelly

On July 5, 2012, 1:09 p.m., Patrick Spendrin wrote:

Re: Review Request: fix exports using Q_DECL_EXPORT

By Thiago Macieira at 07/05/2012 - 10:50

On quinta-feira, 5 de julho de 2012 13.40.48, Stephen Kelly wrote:
If this is about frameworks, it should just use Q_DECL_EXPORT and
Q_DECL_IMPORT. No need to have macros in KDE anymore.

Re: Review Request: fix exports using Q_DECL_EXPORT

By David Faure at 07/05/2012 - 08:25

Ship it!

I think this is the correct solution, i.e. the "for now" in the reviewboard message is wrong :-)

- David Faure

On July 5, 2012, 1:09 p.m., Patrick Spendrin wrote: