DevHeads.net

Review Request: Fix KWidgetItemDelegate not updating on FocusIn and FocusOut

Review request for kdelibs.

Summary (updated)
Fix KWidgetItemDelegate not updating on FocusIn and FocusOut

Description (updated)
KWidgetItemDelegate does not update when the itemView gets or loses the focus.
This may cause problems with the text colors of the selected indexes.

I'm not sure if this is the best way to do it, since in all the other places this is done asyncronously using "QTimer::singleShot(0, this, SLOT(initializeModel()))", but this initializes the whole model, and I think it is not needed here. The alternatives are to update the whole model, or to add another slot to initialize only selected items.

Diffs (updated)
kdeui/itemviews/kwidgetitemdelegate.cpp 828e498

Diff: <a href="http://git.reviewboard.kde.org/r/104149/diff/" title="http://git.reviewboard.kde.org/r/104149/diff/">http://git.reviewboard.kde.org/r/104149/diff/</a>

Testing

Thanks,

Daniele Elmo Domenichelli

Comments

Re: Review Request: Fix KWidgetItemDelegate not updating on Focu

By Commit Hook at 04/16/2012 - 15:47

This review has been submitted with commit 3e23f2046b2854ded3a9b6006c16af19c99ab462 by Daniele E. Domenichelli to branch ivan/solid-fuse-access.

- Commit Hook

On March 4, 2012, 2:58 a.m., Daniele Elmo Domenichelli wrote:

Re: Review Request: Fix KWidgetItemDelegate not updating on Focu

By Commit Hook at 03/12/2012 - 10:19

This review has been submitted with commit 11c7c9adcce7f476b32128f104e2935c6e19ac9d by Daniele E. Domenichelli to branch KDE/4.8.

- Commit Hook

On March 4, 2012, 2:58 a.m., Daniele Elmo Domenichelli wrote:

Re: Review Request: Fix KWidgetItemDelegate not updating on Focu

By Jeremy Paul Whiting at 03/12/2012 - 10:07

Ship it!

Ship It!

- Jeremy Paul Whiting

On March 4, 2012, 2:58 a.m., Daniele Elmo Domenichelli wrote: