DevHeads.net

Review Request: Fix signal/slot connections in kcmdolphinviewmodes

Review request for KDE Base Apps and Peter Penz.

Description
The attached patch fixes a QObject no such slot warning messages in Dolphin's viewmode kcm.

Diffs
dolphin/src/settings/kcm/kcmdolphinviewmodes.h 4ec29db
dolphin/src/settings/kcm/kcmdolphinviewmodes.cpp 5441b78

Diff: <a href="http://git.reviewboard.kde.org/r/104033/diff/" title="http://git.reviewboard.kde.org/r/104033/diff/">http://git.reviewboard.kde.org/r/104033/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Comments

Re: Review Request: Fix signal/slot connections in kcmdolphinvie

By Commit Hook at 02/20/2012 - 19:07

This review has been submitted with commit cfde62cb32ca43ce73ec57117eca29e4fa4d846c by Dawit Alemayehu to branch master.

- Commit Hook

On Feb. 20, 2012, 6:15 p.m., Dawit Alemayehu wrote:

Re: Review Request: Fix signal/slot connections in kcmdolphinvie

By Commit Hook at 02/20/2012 - 19:07

This review has been submitted with commit b484b87376646420a2cd6c568736dfa21b80bf05 by Dawit Alemayehu to branch KDE/4.8.

- Commit Hook

On Feb. 20, 2012, 6:15 p.m., Dawit Alemayehu wrote:

Re: Review Request: Fix signal/slot connections in kcmdolphinvie

By Peter Penz at 02/20/2012 - 14:27

Ship it!

Thanks for the patch, looks fine!

- Peter Penz

On Feb. 20, 2012, 6:15 p.m., Dawit Alemayehu wrote: