DevHeads.net

Review Request: Fix sizing of KMessageWidget when shown at startup

Review request for kdelibs and Dominik Haumann.

Description
When a KMessageWidget is shown at startup, the content width is not correct: it stays at 640 pixels. Attached patch fixes this. Unless someone objects, I'd like to merge it in KDE/4.9.

Diffs
kdeui/widgets/kmessagewidget.cpp b87b3e4

Diff: <a href="http://git.reviewboard.kde.org/r/107336/diff/" title="http://git.reviewboard.kde.org/r/107336/diff/">http://git.reviewboard.kde.org/r/107336/diff/</a>

Testing
Have been running with this patch since for almost a week now. No regressions.

Thanks,

Aurélien Gâteau

Comments

Re: Review Request: Fix sizing of KMessageWidget when shown at s

By Commit Hook at 11/26/2012 - 12:14

This review has been submitted with commit da46ff64c3ef531816864f7b367b416b8e6807c4 by Aurélien Gâteau to branch KDE/4.9.

- Commit Hook

On Nov. 15, 2012, 12:47 p.m., Aurélien Gâteau wrote:

Re: Review Request: Fix sizing of KMessageWidget when shown at s

By Dominik Haumann at 11/19/2012 - 09:40

Ship it!

This fixes the sizing problems for KMessageWidget that we have in Kate.
Your patch simply uses the "best height" in two places now, instead of just one.
I've tested it and it works as expected, so I'd say ship it :-)

- Dominik Haumann

On Nov. 15, 2012, 12:47 p.m., Aurélien Gâteau wrote: