DevHeads.net

Review Request: Fix stray ampersand in KUrlNavigatorProtocolCombo

Review request for Dolphin and kdelibs.

Description
- fix sizeHint to not include the accelerator
- respect styles' hint for showing mnemonics
- respect widgets' enabled() state when drawing the label

This addresses bug 285163.
<a href="http://bugs.kde.org/show_bug.cgi?id=285163" title="http://bugs.kde.org/show_bug.cgi?id=285163">http://bugs.kde.org/show_bug.cgi?id=285163</a>

Diffs
kfile/kurlnavigatorprotocolcombo.cpp 1a08a4c

Diff: <a href="http://git.reviewboard.kde.org/r/103040/diff/diff" title="http://git.reviewboard.kde.org/r/103040/diff/diff">http://git.reviewboard.kde.org/r/103040/diff/diff</a>

Testing

Thanks,

Christoph Feck

Comments

Re: Review Request: Fix stray ampersand in KUrlNavigatorProtocol

By Commit Hook at 11/04/2011 - 04:00

This review has been submitted with commit 3a623c36bc3015a82011fd91cb12ebb22e82c3b4 by Christoph Feck to branch KDE/4.7.

- Commit Hook

On Nov. 3, 2011, 7:27 p.m., Christoph Feck wrote:

Re: Review Request: Fix stray ampersand in KUrlNavigatorProtocol

By Peter Penz at 11/04/2011 - 02:23

Ship it!

Thanks Christoph, looks perfect!

- Peter Penz

On Nov. 3, 2011, 7:27 p.m., Christoph Feck wrote: