DevHeads.net

Review Request: kjs: Implement Object.freeze & Object.isFrozen

Review request for kdelibs.

Description
kjs: Implement Object.freeze & Object.isFrozen

depends on <a href="https://git.reviewboard.kde.org/r/104746/" title="https://git.reviewboard.kde.org/r/104746/">https://git.reviewboard.kde.org/r/104746/</a>

Diffs
kjs/object_object.cpp 986f03f

Diff: <a href="http://git.reviewboard.kde.org/r/104748/diff/" title="http://git.reviewboard.kde.org/r/104748/diff/">http://git.reviewboard.kde.org/r/104748/diff/</a>

Testing
ecmascript 15.2.3.9 tests

Thanks,

Bernd Buschinski

Comments

Re: Review Request 104748: kjs: Implement Object.freeze & Object

By Bernd Buschinski at 01/21/2013 - 22:11

(Updated Jan. 22, 2013, 3:11 a.m.)

Review request for kdelibs.

Changes
- Rebase on KDE/4.10
- Get rid of toString calls in exceptions messages which could also throw an exception

Description
kjs: Implement Object.freeze & Object.isFrozen

depends on <a href="https://git.reviewboard.kde.org/r/104746/" title="https://git.reviewboard.kde.org/r/104746/">https://git.reviewboard.kde.org/r/104746/</a>

Diffs (updated)
kjs/object_object.cpp 39161e2

Diff: <a href="http://git.reviewboard.kde.org/r/104748/diff/" title="http://git.reviewboard.kde.org/r/104748/diff/">http://git.reviewboard.kde.org/r/104748/diff/</a>

Testing
ecmascript 15.2.3.9 tests

Thanks,

Bernd Buschinski

Re: Review Request 104748: kjs: Implement Object.freeze & Object

By Commit Hook at 03/30/2013 - 10:14

(Updated March 30, 2013, 3:14 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs.

Description
kjs: Implement Object.freeze & Object.isFrozen

depends on <a href="https://git.reviewboard.kde.org/r/104746/" title="https://git.reviewboard.kde.org/r/104746/">https://git.reviewboard.kde.org/r/104746/</a>

Diffs
kjs/object_object.cpp 39161e2

Diff: <a href="http://git.reviewboard.kde.org/r/104748/diff/" title="http://git.reviewboard.kde.org/r/104748/diff/">http://git.reviewboard.kde.org/r/104748/diff/</a>

Testing
ecmascript 15.2.3.9 tests

Thanks,

Bernd Buschinski

Re: Review Request 104748: kjs: Implement Object.freeze & Object

By Commit Hook at 03/30/2013 - 10:11

This review has been submitted with commit 75ccf09506ca6884202da03e0ac99977cd14aabb by Bernd Buschinski to branch master.

- Commit Hook

On Jan. 22, 2013, 3:11 a.m., Bernd Buschinski wrote:

Re: Review Request: kjs: Implement Object.freeze & Object.isFroz

By Maks Orlovich at 04/29/2012 - 13:33

Ship it!

Again, looks find except for ->toString in exception messages being risky.

- Maks Orlovich

On April 26, 2012, 8:53 p.m., Bernd Buschinski wrote: