DevHeads.net

Review Request: kjs: Implement Object.isExtensible and Object.preventExtensible

Review request for kdelibs.

Description
kjs: Implement Object.isExtensible and Object.preventExtensible

Also imeplement the changes nesseary to correctly behave on isExtensible or not.
-> allow chaning the value of already existing property, do not allow adding new property.

Diffs
kjs/array_instance.cpp fe9b8b4
kjs/object.h 047c242
kjs/object.cpp c19122f
kjs/object_object.cpp 986f03f
kjs/property_map.h 6b127ff

Diff: <a href="http://git.reviewboard.kde.org/r/104746/diff/" title="http://git.reviewboard.kde.org/r/104746/diff/">http://git.reviewboard.kde.org/r/104746/diff/</a>

Testing
ecmascript 15.2.3.13* test

Thanks,

Bernd Buschinski

Comments

Re: Review Request 104746: kjs: Implement Object.isExtensible an

By Bernd Buschinski at 01/21/2013 - 23:12

(Updated Jan. 22, 2013, 3:12 a.m.)

Review request for kdelibs.

Changes
- Rebase on KDE/4.10 and update to current API.
- Get rid of toString calls in exceptions messages which could also throw an exception

Description
kjs: Implement Object.isExtensible and Object.preventExtensible

Also imeplement the changes nesseary to correctly behave on isExtensible or not.
-> allow chaning the value of already existing property, do not allow adding new property.

Diffs (updated)
kjs/array_instance.cpp 2469316
kjs/object.h 9446349
kjs/object.cpp 9249902
kjs/object_object.cpp 39161e2
kjs/property_map.h a41736a

Diff: <a href="http://git.reviewboard.kde.org/r/104746/diff/" title="http://git.reviewboard.kde.org/r/104746/diff/">http://git.reviewboard.kde.org/r/104746/diff/</a>

Testing
ecmascript 15.2.3.13* test

Thanks,

Bernd Buschinski

Re: Review Request 104746: kjs: Implement Object.isExtensible an

By Commit Hook at 03/30/2013 - 11:14

(Updated March 30, 2013, 3:14 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs.

Description
kjs: Implement Object.isExtensible and Object.preventExtensible

Also imeplement the changes nesseary to correctly behave on isExtensible or not.
-> allow chaning the value of already existing property, do not allow adding new property.

Diffs
kjs/array_instance.cpp 2469316
kjs/object.h 9446349
kjs/object.cpp 9249902
kjs/object_object.cpp 39161e2
kjs/property_map.h a41736a

Diff: <a href="http://git.reviewboard.kde.org/r/104746/diff/" title="http://git.reviewboard.kde.org/r/104746/diff/">http://git.reviewboard.kde.org/r/104746/diff/</a>

Testing
ecmascript 15.2.3.13* test

Thanks,

Bernd Buschinski

Re: Review Request 104746: kjs: Implement Object.isExtensible an

By Commit Hook at 03/30/2013 - 11:11

This review has been submitted with commit 2822fada5c292ecc1bce1f64c887c1531c9bfba1 by Bernd Buschinski to branch master.

- Commit Hook

On Jan. 22, 2013, 3:12 a.m., Bernd Buschinski wrote: