DevHeads.net

Review Request: A KParts extension for filtering listings (ListingFilterExtension)

Review request for kdelibs and David Faure.

Description
The attached patch adds a new extension, ListingFilterExtension, to KParts. The main motivation for this patch is the constant breakage of the Konqueror directory filtering plugin once Konqueror was switched to use Dolphin's part for filemanagement. Because the dolphin part does not expose the same features as the implementation in the old Konqueror file management module, I had to resort to ugly hacks to make this plugin functional. Unfortunately, that hack no longer works properly because of changes/cleanup done in Dolphin's code base. Hence, this patch is an attempt to fix this issue once and for all in a manner that is clean, consistent and useful for any part that wants to provide filtering functionality. As an additional benefit this patch will also makes it very easy to add Dolphin's CTRL+I filtering feature to Konqueror.

The implementation of this extension in Dolphin can be reviewed at <a href="https://git.reviewboard.kde.org/r/106289/" title="https://git.reviewboard.kde.org/r/106289/">https://git.reviewboard.kde.org/r/106289/</a>

Diffs
includes/CMakeLists.txt 8a956ee
includes/KParts/ListingFilterExtension PRE-CREATION
kparts/CMakeLists.txt 96fa31f
kparts/listingfilterextension.h PRE-CREATION
kparts/listingfilterextension.cpp PRE-CREATION

Diff: <a href="http://git.reviewboard.kde.org/r/106288/diff/" title="http://git.reviewboard.kde.org/r/106288/diff/">http://git.reviewboard.kde.org/r/106288/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Comments

Re: Review Request: A KParts extension for filtering listings (L

By Dawit A at 09/04/2012 - 13:09

(Updated Sept. 4, 2012, 6:09 p.m.)

Review request for kdelibs and David Faure.

Changes
- Split the filtering and notification into separate extension. Now there is a ListingFilterExtension and a ListingNotificationExtension. Though related they should not have been combined.

- Renamed the file from listingfilterextension.* to listingextension.*

Description
The attached patch adds a new extension, ListingFilterExtension, to KParts. The main motivation for this patch is the constant breakage of the Konqueror directory filtering plugin once Konqueror was switched to use Dolphin's part for filemanagement. Because the dolphin part does not expose the same features as the implementation in the old Konqueror file management module, I had to resort to ugly hacks to make this plugin functional. Unfortunately, that hack no longer works properly because of changes/cleanup done in Dolphin's code base. Hence, this patch is an attempt to fix this issue once and for all in a manner that is clean, consistent and useful for any part that wants to provide filtering functionality. As an additional benefit this patch will also makes it very easy to add Dolphin's CTRL+I filtering feature to Konqueror.

The implementation of this extension in Dolphin can be reviewed at <a href="https://git.reviewboard.kde.org/r/106289/" title="https://git.reviewboard.kde.org/r/106289/">https://git.reviewboard.kde.org/r/106289/</a>

Diffs (updated)
includes/CMakeLists.txt 8a956ee
includes/KParts/ListingExtension PRE-CREATION
kparts/CMakeLists.txt 96fa31f
kparts/listingextension.h PRE-CREATION
kparts/listingextension.cpp PRE-CREATION

Diff: <a href="http://git.reviewboard.kde.org/r/106288/diff/" title="http://git.reviewboard.kde.org/r/106288/diff/">http://git.reviewboard.kde.org/r/106288/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Re: Review Request: A KParts extension for filtering listings (L

By Dawit A at 09/04/2012 - 14:14

(Updated Sept. 4, 2012, 7:14 p.m.)

Review request for kdelibs and David Faure.

Changes
Updated the API of KParts::ListingNotificationExtension.

Description
The attached patch adds a new extension, ListingFilterExtension, to KParts. The main motivation for this patch is the constant breakage of the Konqueror directory filtering plugin once Konqueror was switched to use Dolphin's part for filemanagement. Because the dolphin part does not expose the same features as the implementation in the old Konqueror file management module, I had to resort to ugly hacks to make this plugin functional. Unfortunately, that hack no longer works properly because of changes/cleanup done in Dolphin's code base. Hence, this patch is an attempt to fix this issue once and for all in a manner that is clean, consistent and useful for any part that wants to provide filtering functionality. As an additional benefit this patch will also makes it very easy to add Dolphin's CTRL+I filtering feature to Konqueror.

The implementation of this extension in Dolphin can be reviewed at <a href="https://git.reviewboard.kde.org/r/106289/" title="https://git.reviewboard.kde.org/r/106289/">https://git.reviewboard.kde.org/r/106289/</a>

Diffs (updated)
kparts/listingextension.cpp PRE-CREATION
includes/CMakeLists.txt 8a956ee
includes/KParts/ListingExtension PRE-CREATION
kparts/CMakeLists.txt 96fa31f
kparts/listingextension.h PRE-CREATION

Diff: <a href="http://git.reviewboard.kde.org/r/106288/diff/" title="http://git.reviewboard.kde.org/r/106288/diff/">http://git.reviewboard.kde.org/r/106288/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Re: Review Request: A KParts extension for filtering listings (L

By Commit Hook at 09/04/2012 - 21:19

This review has been submitted with commit e2e6e5ecb607b545a9154d368aba8f60776dd777 by Dawit Alemayehu to branch KDE/4.9.

- Commit Hook

On Sept. 4, 2012, 7:14 p.m., Dawit Alemayehu wrote:

Re: Review Request: A KParts extension for filtering listings (L

By David Faure at 09/04/2012 - 14:21

Ship it!

kparts/listingextension.cpp
<http://git.reviewboard.kde.org/r/106288/#comment14687>

2010? You've been waiting for a long time to upload this file :-)

- David Faure

On Sept. 4, 2012, 7:14 p.m., Dawit Alemayehu wrote:

Re: Review Request: A KParts extension for filtering listings (L

By Dawit A at 09/04/2012 - 21:02

Got to love copy and paste... :)

- Dawit

On Sept. 4, 2012, 7:14 p.m., Dawit Alemayehu wrote: