DevHeads.net

Review Request: KRecentDocument support for the K Activity Manager Daemon

Review request for kdelibs.

Summary
KRecentDocument now sends info about opened files to the K Activity Manager Daemon so that it can calculate scores for the opened files.

DBus call is made directly instead of using the libkactivities since the library is still in kdelibs/experimental, and the call is quite simple.

Diffs
kio/kfile/krecentdocument.cpp a7f92839e86775e6a2a88073126f1baf6f213e92

Diff: <a href="http://git.reviewboard.kde.org/r/101885/diff" title="http://git.reviewboard.kde.org/r/101885/diff">http://git.reviewboard.kde.org/r/101885/diff</a>

Testing
Been testing for a couple of months now

Thanks,

Ivan

Comments

Re: Review Request: KRecentDocument support for the K Activity M

By Ivan Cukic at 07/20/2011 - 05:11

(Updated July 20, 2011, 10:11 a.m.)

Review request for kdelibs.

Changes
Linking against libs/experimental/libkactivities

Summary
KRecentDocument now sends info about opened files to the K Activity Manager Daemon so that it can calculate scores for the opened files.

DBus call is made directly instead of using the libkactivities since the library is still in kdelibs/experimental, and the call is quite simple.

Diffs (updated)
kio/kfile/krecentdocument.cpp a7f9283

Diff: <a href="http://git.reviewboard.kde.org/r/101885/diff" title="http://git.reviewboard.kde.org/r/101885/diff">http://git.reviewboard.kde.org/r/101885/diff</a>

Testing
Been testing for a couple of months now

Thanks,

Ivan

Re: Review Request: KRecentDocument support for the K Activity M

By Ivan Cukic at 07/20/2011 - 05:16

(Updated July 20, 2011, 10:16 a.m.)

Review request for kdelibs.

Summary
KRecentDocument now sends info about opened files to the K Activity Manager Daemon so that it can calculate scores for the opened files.

DBus call is made directly instead of using the libkactivities since the library is still in kdelibs/experimental, and the call is quite simple.

Diffs (updated)
kio/CMakeLists.txt b517621
kio/kfile/krecentdocument.cpp a7f9283

Diff: <a href="http://git.reviewboard.kde.org/r/101885/diff" title="http://git.reviewboard.kde.org/r/101885/diff">http://git.reviewboard.kde.org/r/101885/diff</a>

Testing
Been testing for a couple of months now

Thanks,

Ivan

Re: Review Request: KRecentDocument support for the K Activity M

By Ivan Cukic at 07/31/2011 - 13:11

(Updated July 31, 2011, 6:11 p.m.)

Review request for kdelibs.

Summary (updated)
KRecentDocument now sends info about opened files to the K Activity Manager Daemon so that it can calculate scores for the opened files.

The event is sent via libkactivities which is in kdelibs experimental

Diffs
kio/CMakeLists.txt b517621
kio/kfile/krecentdocument.cpp a7f9283

Diff: <a href="http://git.reviewboard.kde.org/r/101885/diff" title="http://git.reviewboard.kde.org/r/101885/diff">http://git.reviewboard.kde.org/r/101885/diff</a>

Testing
Been testing for a couple of months now

Thanks,

Ivan

Re: Review Request 101885: KRecentDocument support for the K Act

By Ivan Cukic at 05/01/2015 - 03:21

(Updated May 1, 2015, 8:21 a.m.)

Status
This change has been discarded.

Review request for kdelibs.

Repository: kdelibs

Description
KRecentDocument now sends info about opened files to the K Activity Manager Daemon so that it can calculate scores for the opened files.

The event is sent via libkactivities which is in kdelibs experimental

Diffs
kio/CMakeLists.txt b517621
kio/kfile/krecentdocument.cpp a7f9283

Diff: <a href="https://git.reviewboard.kde.org/r/101885/diff/" title="https://git.reviewboard.kde.org/r/101885/diff/">https://git.reviewboard.kde.org/r/101885/diff/</a>

Testing
Been testing for a couple of months now

Thanks,

Ivan Čukić

Re: Review Request 101885: KRecentDocument support for the K Act

By Albert Astals Cid at 02/09/2013 - 16:53

Wow, this is old, what happened to this?

- Albert Astals Cid

On July 31, 2011, 6:11 p.m., Ivan Čukić wrote:

Re: Review Request 101885: KRecentDocument support for the K Act

By Ivan Cukic at 02/09/2013 - 17:17

Waits for the better days :) (KF5)

- Ivan

On July 31, 2011, 6:11 p.m., Ivan Čukić wrote:

Re: Review Request: KRecentDocument support for the K Activity M

By Aaron J. Seigo at 07/11/2011 - 06:23

aside from the blocking nature of the call which is easily fixable, i'm not in favour of adding specific calls to a specific DBus service that may or may not change implementation at any given point in the future. there's a reason why there is library for this: to hide such things behind a function driven API rather than gluing together DBus calls.

the entire _point_ of having libraries in experimental/ is so that they can be _used_ by code in, e.g., kdelibs or workspace without committing immediately to API stability. if that isn't possible, then we may as well cease kdelibs/experimental/ as it then provides zero benefit.

aside from that, it would make a lot of sense imho to take this opportunity to re-think the mechanism behind KRecentDocument: do we want to continue having a flat file on disk as well as a ranked version of the same data as processed by a desktop events system?

kio/kfile/krecentdocument.cpp
<http://git.reviewboard.kde.org/r/101885/#comment4012>

should be an asyncCall?

- Aaron J.

On July 8, 2011, 5:28 p.m., Ivan Čukić wrote:

Re: Review Request: KRecentDocument support for the K Activity M

By Ivan Cukic at 07/12/2011 - 08:30

Oh, so you'd like to have them link to one another? Ok, can do :)

- Ivan

On July 8, 2011, 5:28 p.m., Ivan Čukić wrote:

Re: Review Request: KRecentDocument support for the K Activity M

By Aaron J. Seigo at 07/12/2011 - 06:26

yes, and that is my point of contention. the reason for kdelibs/experimental is to use the libraries as internal, non-public dependencies to allow them to be tested in real world scenarios before entering 'real world' usage as full fledged members of kdelibs. whoever it was that decided that kdelibs/experimental should be packaged separately and treated as "can't be used as a dependency" made a mistake.

unfortunately i was too busy with other things to notice and correct this mistake in time for 4.7. doesn't mean we have to keep perpetuating it, however.

- Aaron J.

On July 8, 2011, 5:28 p.m., Ivan Čukić wrote:

Re: Review Request: KRecentDocument support for the K Activity M

By Ivan Cukic at 07/11/2011 - 10:07

The reason is quite simple - kdelibs can not depend on kdelibs/experimental

If you recall, that was one of the stoppers for 4.7 because libplasma depended on experimental libkdeclarative (or whatever the name was) and copying the whole libkactivities in private section (like it was the case for the aforementioned) of kio libraries for one single call to the service is a bit too much.

When libkactivities goes out of experimental, we can change this (although, again, making deps between libs for one extremely simple call is something that can be discussed further)

- Ivan

On July 8, 2011, 5:28 p.m., Ivan Čukić wrote:

Re: Review Request: KRecentDocument support for the K Activity M

By Aaron J. Seigo at 07/11/2011 - 09:51

personally, i don't see why libkactivities can not be used here. it literally makes zero sense to have a library in experimental and then not use it because it is experimental. iow, either we get rid of the library and just sprinkle dbus calls and duplicated code everywhere (which would be insane) or we use the library as an internal dependency. how else are we supposed to ensure libkactivities matures? or is the plan to just let it sit there in kdelibs/experimental and never actually be used?

so, no, i'm not personally in favor of seeing this patch go in as-is. i think it should be using libkactivities.

- Aaron J.

On July 8, 2011, 5:28 p.m., Ivan Čukić wrote:

Re: Review Request: KRecentDocument support for the K Activity M

By Ivan Cukic at 07/11/2011 - 06:53

yes, we don't need a return value or anything

apart from that, can I commit?

- Ivan

On July 8, 2011, 5:28 p.m., Ivan Čukić wrote: