DevHeads.net

Review Request: Make KRunner "Enter" work again in 4.10

Review request for kde-workspace and Aaron J. Seigo.

Description
Aaron reverted some code in the 4.9 branch but not in the 4.10 branch where he seemed to not have the bug. Although we all have the bug and thus this patch reverts the code in the same way he did for 4.9. Should also be fixed in master because Enter not working makes KRunner useless.

This addresses bug <a href="https://bugs.kde.org/show_bug.cgi?id=309787" title="https://bugs.kde.org/show_bug.cgi?id=309787">https://bugs.kde.org/show_bug.cgi?id=309787</a>.
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=309787" title="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=309787">http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id...</a>

Diffs
krunner/interfaces/default/interface.cpp fac1066

Diff: <a href="http://git.reviewboard.kde.org/r/108197/diff/" title="http://git.reviewboard.kde.org/r/108197/diff/">http://git.reviewboard.kde.org/r/108197/diff/</a>

Testing
Works as expected

Thanks,

Anne-Marie Mahfouf

Comments

Re: Review Request 108197: Make KRunner "Enter" work again in 4.

By Aaron J. Seigo at 01/15/2013 - 10:30

the reason for the change was that hitting "enter" too quickly would cause nothing to happen. one had to hit "enter" at just the right moment. it was reverted in 4.9 simply because i could not do the testing needed to verify yes/no if it worked or not.

now, i can't seem to replicate the issue, using krunner on a daily basis, that others are seeing with this. perhaps it is a difference in qt version or some such? i'm using 4.8.3 here with the 4.10 branch of kdelibs.

- Aaron J. Seigo

On Jan. 5, 2013, 11:31 a.m., Anne-Marie Mahfouf wrote:

Re: Review Request 108197: Make KRunner "Enter" work again in 4.

By Aaron J. Seigo at 01/15/2013 - 10:30

the reason for the change was that hitting "enter" too quickly would cause nothing to happen. one had to hit "enter" at just the right moment. it was reverted in 4.9 simply because i could not do the testing needed to verify yes/no if it worked or not.

now, i can't seem to replicate the issue, using krunner on a daily basis, that others are seeing with this. perhaps it is a difference in qt version or some such? i'm using 4.8.3 here with the 4.10 branch of kdelibs.

- Aaron J. Seigo

On Jan. 5, 2013, 11:31 a.m., Anne-Marie Mahfouf wrote: