DevHeads.net

Review Request: make QTEST_KDEMAIN_CORE_WITH_COMPONENTNAME compile with -DQT_NO_CAST_FROM_ASCII

Review request for kdelibs.

Summary
QTEST_KDEMAIN_WITH_COMPONENTNAME already has QLatin1String/QString::fromLatin1 wrappers, but QTEST_KDEMAIN_CORE_WITH_COMPONENTNAME was still missing them.
Should not do any harm to add QLatin1String wrappers in the macro, but I am tired and might miss something, so up for review :)

Diffs
kdecore/util/qtest_kde.h 29f08e5

Diff: <a href="http://git.reviewboard.kde.org/r/101444/diff" title="http://git.reviewboard.kde.org/r/101444/diff">http://git.reviewboard.kde.org/r/101444/diff</a>

Testing
My test programs using "QTEST_KDEMAIN_CORE( TestName )" now compile with -DQT_NO_CAST_FROM_ASCII

Thanks,

Friedrich W. H.

Comments

Re: Review Request: make QTEST_KDEMAIN_CORE_WITH_COMPONENTNAME c

By Commit Hook at 05/27/2011 - 10:25

This review has been submitted with commit cbbbc79a5df68f3a43e55f2e60caab1ccb80118b by Friedrich W. H. Kossebau.

- Commit

On May 26, 2011, 10:01 p.m., Friedrich W. H. Kossebau wrote:

Re: Review Request: make QTEST_KDEMAIN_CORE_WITH_COMPONENTNAME c

By Aaron J. Seigo at 05/27/2011 - 04:56

Ship it!

looks good.

- Aaron J.

On May 26, 2011, 10:01 p.m., Friedrich W. H. Kossebau wrote: