DevHeads.net

Review Request: miscelaneous things

Review request for kdelibs.

Description
1. change order between setting parent d-> property and deleting this d->. (Probably does nothing)
2. Assign directly this to o pointer
3. Avoid the use of a possible null pointer (it is checked before) propAnim

Diffs
plasma/containment.cpp 5f13c2b
plasma/datacontainer.cpp fd1ad89
plasma/private/applethandle.cpp f6d51a2

Diff: <a href="http://git.reviewboard.kde.org/r/106782/diff/" title="http://git.reviewboard.kde.org/r/106782/diff/">http://git.reviewboard.kde.org/r/106782/diff/</a>

Testing
This has helped me to know more about bug 297684
(that I still suffer :-( )

Thanks,

Jaime Torres Amate

Comments

Re: Review Request: miscelaneous things for kdelibs/plasma

By Jaime Torres Amate at 10/10/2012 - 10:41

(Updated Oct. 10, 2012, 3:41 p.m.)

Review request for kdelibs and Plasma.

Summary (updated)
miscelaneous things for kdelibs/plasma

Description
1. change order between setting parent d-> property and deleting this d->. (Probably does nothing)
2. Assign directly this to o pointer
3. Avoid the use of a possible null pointer (it is checked before) propAnim

Diffs
plasma/containment.cpp 5f13c2b
plasma/datacontainer.cpp fd1ad89
plasma/private/applethandle.cpp f6d51a2

Diff: <a href="http://git.reviewboard.kde.org/r/106782/diff/" title="http://git.reviewboard.kde.org/r/106782/diff/">http://git.reviewboard.kde.org/r/106782/diff/</a>

Testing
This has helped me to know more about bug 297684
(that I still suffer :-( )

Thanks,

Jaime Torres Amate

Re: Review Request: miscelaneous things for kdelibs/plasma

By Commit Hook at 10/10/2012 - 12:12

This review has been submitted with commit 168961c452d09c8d0c299012aa8f07a10d764182 by Jaime Torres to branch KDE/4.10.

- Commit Hook

On Oct. 10, 2012, 3:41 p.m., Jaime Torres Amate wrote:

Re: Review Request: miscelaneous things for kdelibs/plasma

By David Edmundson at 10/10/2012 - 10:56

Ship it!

Looks good to me.

- David Edmundson

On Oct. 10, 2012, 3:41 p.m., Jaime Torres Amate wrote:

Re: Review Request: miscelaneous things for kdelibs/plasma

By Marco Martin at 10/10/2012 - 10:59

Ship it!

Ship It!

- Marco Martin

On Oct. 10, 2012, 3:41 p.m., Jaime Torres Amate wrote: