Review request for KDE Runtime and Andreas Schneider.
This is the last one of the sftp login fixes series and addresses the following problems:
#1. Correctly handle login failure that results from a different username being used when setting the
SSH_OPTIONS_USER option and calling ssh_userauth_password. I think this might have been due to
a regression caused by my previous patch. Nonetheless, this patch addresses it.
#2. Changed public key authentication so that incorrect public key passwords generate a retry dialog
instead of simply continuing to the next available authentication method.
Diff: <a href="http://git.reviewboard.kde.org/r/104642/diff/" title="http://git.reviewboard.kde.org/r/104642/diff/">http://git.reviewboard.kde.org/r/104642/diff/</a>
Testing for #1:
1.) Make sure a ssh server is running on your system.
2.) Attempt to login into your system: sftp://127.0.0.1.
3.) When prompted for credentials, enter a user name other than the currently logged in user.
Login attempt will simply fail eventually and and error page is displayed.
New (Fixed) Behavior:
Successfully log into the server with the specified user name.
Testing for #2:
1.) Create a ssh key with password protection and add it to the authorized_keys file.
2.) Make sure the ssh public key is in your .ssh directory.
3.) Attempt to login into your system: sftp://127.0.0.1
4.) When prompted for the passpharse for the key, enter a bogus password.
No retry dialog is ever shown for an invalid or improper ssh key passphrase and the process simply moves on to the next authentication method.
Show a retry dialog if the failure is due to invalid password. If the user then presses cancel on the retry dialog, simply behave the same way as if the cancel button is pressed on the password dialog. That is continue onto the next authentication method.
|KF5 Update Meeting Minutes 2014-w9||0|
|Review Request 110799: Remove translation via babelfish - service is no longer avaibable - use google as default||3|
|Review Request 122784: Fix 404 result for all api calls.||2|
|Review Request 110514: Me more precise about the error message in case KSaveFile fails.||3|
|Review Request: elide completion entries in the middle in konq-address completion list||3|
|Pre-merge CI for Gerrit||4|
|Review Request 119021: Forward port fix for 142957 to kinit in frameworks||4|
|window titles with modified status||1|
|Hunting a memory leak in KMail||2|