DevHeads.net

Review Request: New KLauncher DBus interface to check for on hold ioslave for a given url

Review request for kdelibs.

Summary
As the summary state, this patch adds a new dbus interface to klaucher, checkForHeldSlave, that can be used to check whether or not there is an io slave being held for a given url. This fixes the last known issue with KIO's put-on-hold feature not working properly. With this patch when a user clicks on a PDF link that points to an ftp server, KIO will no longer require multiple connections to service that single request.

Please note that this fix is not specific to the ftp ioslave. Any ioslave that optimizes its copy operation, i.e. supports the canCopyFromFile/canCopyToFile properties, benefits from this fix.

Diffs
kdecore/util/klauncher_iface.h 02c6c9b
kinit/klauncher.h 3fbf2d7
kinit/klauncher.cpp dd45dfe
kinit/klauncher_adaptor.h 0b045c8
kinit/klauncher_adaptor.cpp c7cf086
kio/kio/scheduler.cpp 34f437e
kio/kio/slave.h 780f3c4
kio/kio/slave.cpp 3679ea9

Diff: <a href="http://git.reviewboard.kde.org/r/101333/diff" title="http://git.reviewboard.kde.org/r/101333/diff">http://git.reviewboard.kde.org/r/101333/diff</a>

Testing

Thanks,

Dawit

Comments

Re: Review Request: New KLauncher DBus interface to check for on

By Dawit A at 05/11/2011 - 10:58

(Updated May 11, 2011, 3:58 p.m.)

Review request for kdelibs.

Changes
Updated testing information...

Summary
As the summary state, this patch adds a new dbus interface to klaucher, checkForHeldSlave, that can be used to check whether or not there is an io slave being held for a given url. This fixes the last known issue with KIO's put-on-hold feature not working properly. With this patch when a user clicks on a PDF link that points to an ftp server, KIO will no longer require multiple connections to service that single request.

Please note that this fix is not specific to the ftp ioslave. Any ioslave that optimizes its copy operation, i.e. supports the canCopyFromFile/canCopyToFile properties, benefits from this fix.

Diffs
kdecore/util/klauncher_iface.h 02c6c9b
kinit/klauncher.h 3fbf2d7
kinit/klauncher.cpp dd45dfe
kinit/klauncher_adaptor.h 0b045c8
kinit/klauncher_adaptor.cpp c7cf086
kio/kio/scheduler.cpp 34f437e
kio/kio/slave.h 780f3c4
kio/kio/slave.cpp 3679ea9

Diff: <a href="http://git.reviewboard.kde.org/r/101333/diff" title="http://git.reviewboard.kde.org/r/101333/diff">http://git.reviewboard.kde.org/r/101333/diff</a>

Testing (updated)
Clicking on the example links below should only result in one single connection to the server:

<a href="ftp://ftp.kde.org/pub/kde/README_UPLOAD" title="ftp://ftp.kde.org/pub/kde/README_UPLOAD">ftp://ftp.kde.org/pub/kde/README_UPLOAD</a>
<a href="ftp://ftp.kde.org/pub/kde/printing/kdeprint-handbook.pdf" title="ftp://ftp.kde.org/pub/kde/printing/kdeprint-handbook.pdf">ftp://ftp.kde.org/pub/kde/printing/kdeprint-handbook.pdf</a>

Thanks,

Dawit

Re: Review Request: New KLauncher DBus interface to check for on

By Commit Hook at 05/11/2011 - 11:47

This review has been submitted with commit c6ae48ccb5e809057a2d83888ad9181b2e5bc0ce by Dawit Alemayehu.

- Commit

On May 11, 2011, 3:58 p.m., Dawit Alemayehu wrote:

Re: Review Request: New KLauncher DBus interface to check for on

By Thiago Macieira at 05/11/2011 - 11:35

Ship it!

Looks good. Lots of monkey work to get a small change...

- Thiago

On May 11, 2011, 3:58 p.m., Dawit Alemayehu wrote: