DevHeads.net

Review Request: Part II: cookie configuration dialog to support the accept cookie for session option

Review request for KDE Base Apps.

Description
This is the configuration dialog portion of the patch necessary to convert the global "Treat all cookies as session cookies" option into a per domain or per cookie configuration. This patch completes the patch posted at <a href="https://git.reviewboard.kde.org/r/106618/" title="https://git.reviewboard.kde.org/r/106618/">https://git.reviewboard.kde.org/r/106618/</a>.

This addresses bug 54300.
<a href="http://bugs.kde.org/show_bug.cgi?id=54300" title="http://bugs.kde.org/show_bug.cgi?id=54300">http://bugs.kde.org/show_bug.cgi?id=54300</a>

Diffs
konqueror/settings/kio/kcookiespolicies.h b035ad5
konqueror/settings/kio/kcookiespolicies.cpp 75d265f
konqueror/settings/kio/kcookiespolicies.ui 6b88b80
konqueror/settings/kio/kcookiespolicyselectiondlg.h d40a0f2
konqueror/settings/kio/kcookiespolicyselectiondlg.ui c7ebb5d

Diff: <a href="http://git.reviewboard.kde.org/r/106619/diff/" title="http://git.reviewboard.kde.org/r/106619/diff/">http://git.reviewboard.kde.org/r/106619/diff/</a>

Testing

Screenshots
New Cookie Config dialog
<a href="http://git.reviewboard.kde.org/r/106619/s/737/" title="http://git.reviewboard.kde.org/r/106619/s/737/">http://git.reviewboard.kde.org/r/106619/s/737/</a>

Thanks,

Dawit Alemayehu

Comments

Re: Review Request: Part II: cookie configuration dialog to supp

By Commit Hook at 09/30/2012 - 13:21

This review has been submitted with commit 930e19b9a7244b45b9fc830b34a09fdc1b2fb3c8 by Dawit Alemayehu to branch master.

- Commit Hook

On Sept. 28, 2012, 4:46 a.m., Dawit Alemayehu wrote:

Re: Review Request: Part II: cookie configuration dialog to supp

By David Faure at 09/30/2012 - 04:39

Ship it!

konqueror/settings/kio/kcookiespolicies.cpp
<http://git.reviewboard.kde.org/r/106619/#comment15624>

That's a weird variable name for an item... a bit confusing.

konqueror/settings/kio/kcookiespolicies.cpp
<http://git.reviewboard.kde.org/r/106619/#comment15625>

Use .value() instead of [] to prevent accidental insertion.

- David Faure

On Sept. 28, 2012, 4:46 a.m., Dawit Alemayehu wrote: