DevHeads.net

Review Request: proper fix for my inexcusable commit without review

Review request for kdelibs.

Description
the action created locally in void KAction::setAuthAction(const QString &actionName) is deleted.
The others must be handled by the callers of void KAction::setAuthAction(KAuth::Action *action).

Diffs
kdeui/actions/kaction.cpp 0f6343c
kdeui/actions/kaction_p.h 26f2b77

Diff: <a href="http://git.reviewboard.kde.org/r/105364/diff/" title="http://git.reviewboard.kde.org/r/105364/diff/">http://git.reviewboard.kde.org/r/105364/diff/</a>

Testing
working with it this afternoon.

Thanks,

Jaime Torres Amate

Comments

Re: Review Request: proper fix for my inexcusable commit without

By Jaime Torres Amate at 06/29/2012 - 12:22

(Updated June 29, 2012, 4:22 p.m.)

Review request for kdelibs.

Changes
It is not possible to fix the memory leak in void KAction::setAuthAction(const QString &actionName) the way I tried.
kdelibs will have it until frameworks is ready.
Therefore, replace the delete by just two comments.

Description
the action created locally in void KAction::setAuthAction(const QString &actionName) is deleted.
The others must be handled by the callers of void KAction::setAuthAction(KAuth::Action *action).

Diffs (updated)
kdeui/actions/kaction.cpp 0f6343c

Diff: <a href="http://git.reviewboard.kde.org/r/105364/diff/" title="http://git.reviewboard.kde.org/r/105364/diff/">http://git.reviewboard.kde.org/r/105364/diff/</a>

Testing
working with it this afternoon.

Thanks,

Jaime Torres Amate

Re: Review Request: proper fix for my inexcusable commit without

By David Faure at 07/11/2012 - 08:25

Ship it!

Ship It!

- David Faure

On June 29, 2012, 4:22 p.m., Jaime Torres Amate wrote:

Re: Review Request: proper fix for my inexcusable commit without

By Jaime Torres Amate at 07/11/2012 - 10:53

Should i commit it to branch KDE/4.8 & 4.9? (Do i have to send any email to the release team?)

David Faure < ... at kde dot org> escribió:

Re: Review Request: proper fix for my inexcusable commit without

By David Faure at 07/11/2012 - 12:30

On Wednesday 11 July 2012 16:53:33 Jaime Torres Amate wrote:
If this fixes a frequent/severe crash in 4.9, then yes, and yes.