DevHeads.net

Review Request: remove functions *Command::name() which are not used

Review request for KDE Base Apps and David Faure.

Summary
konq-plugins/domtreeviewer builds without there functions.

May be these functions were left for future integration of domtreeviewer undoable commands' into Konqueror's undo stack. But for now, they only add a few translatable strings the user won't ever see.

Diffs
konq-plugins/domtreeviewer/domtreecommands.h df8272e
konq-plugins/domtreeviewer/domtreecommands.cpp e4c7fff

Diff: <a href="http://git.reviewboard.kde.org/r/101343/diff" title="http://git.reviewboard.kde.org/r/101343/diff">http://git.reviewboard.kde.org/r/101343/diff</a>

Testing
konq-plugins/domtreeviewer compiles after this change.

Thanks,

Alexander

Comments

Re: Review Request 101343: remove functions *Command::name() whi

By Albert Astals Cid at 02/16/2014 - 12:12

Alexander, did you see David's comment? Do you plan to implement what he suggests?

- Albert Astals Cid

On May 12, 2011, 6:55 a.m., Alexander Potashev wrote:

Re: Review Request: remove functions *Command::name() which are

By David Faure at 06/05/2011 - 18:48

OK, that's one solution. The other solution would be to fix the Undo action to actually show the text of the command to undo, like it does in many other apps ;)

Looking at keditbookmarks, it seems to do that using QUndoStack::createUndoAction, which makes sure that the action text is always updated from the text of the current undo command.

- David

On May 12, 2011, 6:55 a.m., Alexander Potashev wrote: