DevHeads.net

Review Request: Require Qt 4.8 in kdelibs KDE/4.8 branch

Review request for kdelibs.

Description
Since <a href="https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=86dcd810bc7bb1effb7a2831d0e7d49cab6e120d" title="https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=86dcd810bc7bb1effb7a2831d0e7d49cab6e120d">https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=86dcd8...</a> kdelibs KDE/4.8 requires Qt 4.8. Without it we get the following build error:
kdecore/network/ktcpsocket.cpp:47:10: error: ‘TlsV1SslV3’ is not a member of ‘QSsl’
kdecore/network/ktcpsocket.cpp:49:10: error: ‘SecureProtocols’ is not a member of ‘QSsl’

Given thread <a href="http://lists.kde.org/?l=kde-core-devel&amp;m=133405344728456&amp;w=2" title="http://lists.kde.org/?l=kde-core-devel&amp;m=133405344728456&amp;w=2">http://lists.kde.org/?l=kde-core-devel&amp;m=133405344728456&amp;w=2</a> I think it is best to require Qt 4.8 in CMake to get proper warnings at cmake check and not get a useless build error.

Diffs
CMakeLists.txt 040a24f

Diff: <a href="http://git.reviewboard.kde.org/r/104593/diff/" title="http://git.reviewboard.kde.org/r/104593/diff/">http://git.reviewboard.kde.org/r/104593/diff/</a>

Testing

Thanks,

Martin Gräßlin

Comments

Re: Review Request: Require Qt 4.8 in kdelibs KDE/4.8 branch

By Dawit A at 04/13/2012 - 16:51

The commit that has caused the compilation problem has already been addressed:

<a href="http://commits.kde.org/kdelibs/cd71839b04d7c754b9ec18f7b56522958b504006" title="http://commits.kde.org/kdelibs/cd71839b04d7c754b9ec18f7b56522958b504006">http://commits.kde.org/kdelibs/cd71839b04d7c754b9ec18f7b56522958b504006</a>
<a href="http://commits.kde.org/kdelibs/d82f313500f9e4fe3a7e5ddef43650c31b59c8e3" title="http://commits.kde.org/kdelibs/d82f313500f9e4fe3a7e5ddef43650c31b59c8e3">http://commits.kde.org/kdelibs/d82f313500f9e4fe3a7e5ddef43650c31b59c8e3</a>

- Dawit Alemayehu

On April 13, 2012, 8:07 p.m., Martin Gräßlin wrote:

Re: Review Request: Require Qt 4.8 in kdelibs KDE/4.8 branch

By Andre Heinecke at 05/16/2012 - 07:48

Happened again with <a href="https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=2cf247f4ebdee44d0620e57f9cd17fa963b36b73" title="https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=2cf247f4ebdee44d0620e57f9cd17fa963b36b73">https://projects.kde.org/projects/kde/kdelibs/repository/diff?rev=2cf247...</a>
The QNetworkReply::setFinished ( <a href="http://qt-project.org/doc/qt-4.8/qnetworkreply.html#setFinished" title="http://qt-project.org/doc/qt-4.8/qnetworkreply.html#setFinished">http://qt-project.org/doc/qt-4.8/qnetworkreply.html#setFinished</a> ) was introduced in Qt 4.8

- Andre

On April 13, 2012, 8:07 p.m., Martin Gräßlin wrote:

Re: Review Request: Require Qt 4.8 in kdelibs KDE/4.8 branch

By Martin =?iso-88... at 04/14/2012 - 00:55

thanks for the info - no idea why I did not find that one yesterday...

- Martin

On April 13, 2012, 8:07 p.m., Martin Gräßlin wrote: