DevHeads.net

Review Request: Show the correct remote charset in encoding in Konqueror and Dolphin.

Review request for KDE Base Apps and Peter Penz.

Description
The attached patch fixes a logic error in the code that determines which remote encoding should be checked when the "Show Remote Encoding" menu is shown. The logic flaw only affects when the user chooses an encoding which has similar types, e.g. ISO-8859-1*.

This addresses bug 186289.
<a href="http://bugs.kde.org/show_bug.cgi?id=186289" title="http://bugs.kde.org/show_bug.cgi?id=186289">http://bugs.kde.org/show_bug.cgi?id=186289</a>

Diffs
dolphin/src/views/dolphinremoteencoding.cpp 8644f5c

Diff: <a href="http://git.reviewboard.kde.org/r/103730/diff/diff" title="http://git.reviewboard.kde.org/r/103730/diff/diff">http://git.reviewboard.kde.org/r/103730/diff/diff</a>

Testing
1.) Connect to a remote server.
2.) Change the remote charset encoding to "Western European ( ISO-8859-1 )".
3.) Go back to the remote encoding and check what is selected.

Thanks,

Dawit Alemayehu

Comments

Re: Review Request: Show the correct remote charset encoding in

By Dawit A at 01/18/2012 - 15:03

(Updated Jan. 18, 2012, 7:03 p.m.)

Review request for KDE Base Apps and Peter Penz.

Summary (updated)
Show the correct remote charset encoding in Konqueror's and Dolphin's "Set Remote Encoding" menu

Description
The attached patch fixes a logic error in the code that determines which remote encoding should be checked when the "Show Remote Encoding" menu is shown. The logic flaw only affects when the user chooses an encoding which has similar types, e.g. ISO-8859-1*.

This addresses bug 186289.
<a href="http://bugs.kde.org/show_bug.cgi?id=186289" title="http://bugs.kde.org/show_bug.cgi?id=186289">http://bugs.kde.org/show_bug.cgi?id=186289</a>

Diffs
dolphin/src/views/dolphinremoteencoding.cpp 8644f5c

Diff: <a href="http://git.reviewboard.kde.org/r/103730/diff/diff" title="http://git.reviewboard.kde.org/r/103730/diff/diff">http://git.reviewboard.kde.org/r/103730/diff/diff</a>

Testing
1.) Connect to a remote server.
2.) Change the remote charset encoding to "Western European ( ISO-8859-1 )".
3.) Go back to the remote encoding and check what is selected.

Thanks,

Dawit Alemayehu

Re: Review Request: Show the correct remote charset encoding in

By Commit Hook at 01/18/2012 - 19:05

This review has been submitted with commit e824021d45a989ec75776f14082d6af62223715d by Dawit Alemayehu to branch master.

- Commit Hook

On Jan. 18, 2012, 7:03 p.m., Dawit Alemayehu wrote:

Re: Review Request: Show the correct remote charset encoding in

By Commit Hook at 01/18/2012 - 19:05

This review has been submitted with commit 8f231bd08134f7b1870a9c1747429c1b05174d62 by Dawit Alemayehu to branch KDE/4.8.

- Commit Hook

On Jan. 18, 2012, 7:03 p.m., Dawit Alemayehu wrote:

Re: Review Request: Show the correct remote charset encoding in

By Peter Penz at 01/18/2012 - 16:19

Ship it!

Thanks for the patch, looks fine!

- Peter Penz

On Jan. 18, 2012, 7:03 p.m., Dawit Alemayehu wrote: