DevHeads.net

Review Request: Umpteenth try to fix KCharSelect crash

Review request for kdelibs and Albert Astals Cid.

Summary
This is definitively my last try to fix the KCharSelect crash.

This addresses bug 235020.
<a href="http://bugs.kde.org/show_bug.cgi?id=235020" title="http://bugs.kde.org/show_bug.cgi?id=235020">http://bugs.kde.org/show_bug.cgi?id=235020</a>

Diffs
kdeui/widgets/kcharselect.cpp c511191
kdeui/widgets/kcharselect_p.h d414d23

Diff: <a href="http://git.reviewboard.kde.org/r/102263/diff" title="http://git.reviewboard.kde.org/r/102263/diff">http://git.reviewboard.kde.org/r/102263/diff</a>

Testing
I NEVER could reproduce the crash, so I don't know if this changes anything at all.

Thanks,

Christoph

Comments

Re: Review Request: Umpteenth try to fix KCharSelect crash

By Commit Hook at 08/20/2011 - 05:06

This review has been submitted with commit 0e4754a0eacd4528a4d2b369704afca9f36e366f by Christoph Feck to branch KDE/4.7.

- Commit

On Aug. 9, 2011, 4:34 p.m., Christoph Feck wrote:

Re: Review Request: Umpteenth try to fix KCharSelect crash

By Albert Astals Cid at 08/10/2011 - 04:05

Fixes the crash for me.

- Albert

On Aug. 9, 2011, 4:34 p.m., Christoph Feck wrote: