DevHeads.net

Review Request: Unbreak the build on Windows as there is no "uint" type recognized

Review request for kdelibs and David Faure.

Description
There may be another approaches for fixing this build issue I have not yet discovered, hence putting for review.

Diffs
kjs/jsonstringify.cpp f816e98

Diff: <a href="http://git.reviewboard.kde.org/r/106539/diff/" title="http://git.reviewboard.kde.org/r/106539/diff/">http://git.reviewboard.kde.org/r/106539/diff/</a>

Testing
Build test

Thanks,

Laszlo Papp

Comments

Re: Review Request: Unbreak the build on Windows as there is no

By Commit Hook at 09/24/2012 - 06:56

This review has been submitted with commit 700b8778b10232c9b416a1196886cd3a2fdf5680 by Laszlo Papp to branch KDE/4.9.

- Commit Hook

On Sept. 23, 2012, 8 a.m., Laszlo Papp wrote:

Re: Review Request: Unbreak the build on Windows as there is no

By David Faure at 09/24/2012 - 06:22

Ship it!

Ship It!

- David Faure

On Sept. 23, 2012, 8 a.m., Laszlo Papp wrote:

Re: Review Request: Unbreak the build on Windows as there is no

By Laszlo Papp at 09/23/2012 - 04:19

kjs/jsonstringify.cpp
<http://git.reviewboard.kde.org/r/106539/#comment15300>

We could also include "WinDef.h", but that would need ifdef'ing or finding a separate place where there is already a windows branching and alos appropriate for this.

Since it only affects one line here as it seems so far, probably it is just better not to spare few characters here, but I do not mind either way. :-)

- Laszlo Papp

On Sept. 23, 2012, 8 a.m., Laszlo Papp wrote: