DevHeads.net

Review Request: User-friendly error messages in Solid

Review request for kdelibs, Pino Toscano and Kevin Ottens.

Summary
This patch extends the Solid::ErrorType enum and provides more meaningful (and translatable) error messages for the solid-udisks backend.

This addresses bug 265673.
<a href="http://bugs.kde.org/show_bug.cgi?id=265673" title="http://bugs.kde.org/show_bug.cgi?id=265673">http://bugs.kde.org/show_bug.cgi?id=265673</a>

Diffs
solid/solid/backends/udisks/udisksopticaldrive.cpp 72aa401
solid/solid/backends/udisks/udisksstorageaccess.cpp 28a8d22
solid/solid/solidnamespace.h a795041
solid/solid/backends/udisks/udisksdevice.h adf6eae
solid/solid/backends/udisks/udisksdevice.cpp 9bf04a0
solid/solid/backends/udisks/udisks.h ec9fa2c

Diff: <a href="http://git.reviewboard.kde.org/r/100603/diff" title="http://git.reviewboard.kde.org/r/100603/diff">http://git.reviewboard.kde.org/r/100603/diff</a>

Testing

Thanks,

Lukáš

Comments

Re: Review Request: User-friendly error messages in Solid

By Kevin Ottens at 02/10/2011 - 03:29

solid/solid/solidnamespace.h
<http://git.reviewboard.kde.org/r/100603/#comment1106>

DeviceBusy

solid/solid/solidnamespace.h
<http://git.reviewboard.kde.org/r/100603/#comment1105>

OperationFailed

solid/solid/solidnamespace.h
<http://git.reviewboard.kde.org/r/100603/#comment1107>

UserCanceled? What's the source of this cancellation?

- Kevin

On Feb. 7, 2011, 7:11 p.m., Lukáš Tinkl wrote:

Re: Review Request: User-friendly error messages in Solid

By todd rme at 02/07/2011 - 14:43

2011/2/7 Lukáš Tinkl < ... at kde dot org>

I am not sure this is the place for it, but in the case of a device being
busy, is it possible to say what program is using the device so the user can
close it?

-Todd

Re: Review Request: User-friendly error messages in Solid

By =?iso-8859-15?q... at 02/08/2011 - 08:17

Dne Po 7. února 2011 20:43:05 todd rme napsal(a):
Yes it's possible, actually a good idea :)