DevHeads.net

Updating our tools

Hello all,

Since some of our applications and our workspace will be updated for
the next major release (14.12 is the name iirc) to use Qt5 and KDE
Frameworks I thought I would check englishbreakfastnetwork.org code
checker of kanagram (which has master branch based on qt5 and kf5).
<a href="http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/kanagram/index.html" title="http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/kanagram/index.html">http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/kanagram/index.html</a>
Some of the "issues" on krazy are old and point to techbase articles
suggesting the opposite of the kf5 porting notes, For example, krazy
suggests we should use KLineEdit instead of QLineEdit but the porting
notes suggest to port from KLineEdit to QLineEdit since KLineEdit is
to be deprecated. Maybe I just missed something on ebn, but do we need
to add another category there for kf5 based code to be checked in a
different way with different rules, etc.? Shouldn't we update pages
like <a href="https://techbase.kde.org/Policies/API_to_Avoid" title="https://techbase.kde.org/Policies/API_to_Avoid">https://techbase.kde.org/Policies/API_to_Avoid</a> to reflect new
suggestions also I guess or split them to contain suggestions for
kdelibs4 based code vs kf5 based code?

thanks,
Jeremy

Comments

Re: Updating our tools

By Albert Astals Cid at 09/23/2014 - 17:01

El Dimarts, 23 de setembre de 2014, a les 15:56:58, Jeremy Whiting va
escriure:
We totally should, now who is going to do it ;)

Cheers,
Albert

Re: Updating our tools

By Jeremy Paul Whiting at 09/23/2014 - 17:15

Albert,

I can take a look at it if someone points me in the right direction. I
also found this:
<a href="http://ebn.kde.org/krazy/reports/frameworks-5.x/kdelibs/knewstuff/index.html" title="http://ebn.kde.org/krazy/reports/frameworks-5.x/kdelibs/knewstuff/index.html">http://ebn.kde.org/krazy/reports/frameworks-5.x/kdelibs/knewstuff/index....</a>
which seems to check the right way for frameworks suggestions, but it
hasn't been ran since Dec of last year :/ and also it calls the
frameworks kdelibs still (or at least puts it in the url) So it seems
krazy can handle this new set of suggestions (maybe it could use some
tweaks though) but hasn't been ran in quite some time. How do I get
access to run it more often, etc.

BR,
Jeremy

On Tue, Sep 23, 2014 at 4:01 PM, Albert Astals Cid < ... at kde dot org> wrote:

Re: Updating our tools

By Allen Winter at 09/24/2014 - 09:13

On Tuesday, September 23, 2014 04:15:27 PM Jeremy Whiting wrote:
Yes that's all on my plate.
I have it on my todo list.
Krazy should be kde5 ready , I just need to plug it in and turn it on.

I don't recall if there were any blockers, or if I simply got distracted on something else.

The associated changes to the techbase documentation is not on my radar.

Re: Updating our tools

By vivo75@gmail.com at 09/24/2014 - 14:23

Il 24/09/2014 16:13, Allen Winter ha scritto:

Re: Updating our tools

By Jeremy Paul Whiting at 09/24/2014 - 11:38

Allen,

Thanks for fixing this, I think it will be a useful tool to check our
existing frameworks and code based on frameworks with. I'll update the
techbase pages myself.

thanks,
Jeremy

On Wed, Sep 24, 2014 at 8:13 AM, Allen Winter < ... at kde dot org> wrote:

Re: Updating our tools

By Allen Winter at 09/28/2014 - 11:28

On Wednesday, September 24, 2014 10:38:37 AM Jeremy Whiting wrote:

Re: Updating our tools

By Elvis Angelaccio at 08/08/2015 - 09:59

Sorry to bump this old thread, but it looks like Krazy still complains
about kdelibs4 errors even if an application is now KF5 based.
For instance consider again Kanagram:
<a href="http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/kanagram/index.html" title="http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/kanagram/index.html">http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/kanagram/index.html</a>

Am I missing something? Is there another page showing KF5-related issues
for KF5-ready apps?

Cheers,
Elvis

2014-09-28 18:28 GMT+02:00 Allen Winter < ... at kde dot org>:

Re: Updating our tools

By Allen Winter at 08/08/2015 - 10:15

On Saturday, August 08, 2015 04:59:49 PM Elvis Angelaccio wrote:
If Krazy is running in the kde-4.x component, then it does use the KDE4 checkers.

For now, Krazy only knows its looking at KF5 code if it's running in the frameworks 5 component in
<a href="http://ebn.kde.org/krazy/index.php?component=frameworks&amp;module=frameworks5" title="http://ebn.kde.org/krazy/index.php?component=frameworks&amp;module=frameworks5">http://ebn.kde.org/krazy/index.php?component=frameworks&amp;module=frameworks5</a>

I don't see kanagram listed in the frameworks5 component.

The KDE projects also lists kanagram in kde-4.x only, as far as I can tell.
So first step is to get kanagram listed as a frameworks project.

Re: Updating our tools

By Ben Cooksley at 08/09/2015 - 04:35

On Sun, Aug 9, 2015 at 3:15 AM, Allen Winter < ... at kde dot org> wrote:
To my knowledge there isn't anything on projects.kde.org which states
a project is kde-4.x only. Where is this information coming from?

Regards,
Ben

Re: Updating our tools

By Allen Winter at 08/09/2015 - 08:58

On Sunday, August 09, 2015 09:35:06 PM Ben Cooksley wrote:
I see that kanagram master is kf5 based but is not part of frameworks.
therefore I will need to invent a way to detect that a project is kf5 based.
do we have an easy way to detect kde4 vs. kf5 projects?

Re: Updating our tools

By Michael Pyne at 08/09/2015 - 09:49

On Sun, August 9, 2015 09:58:26 Allen Winter wrote:
The only way I'm aware of is to use the kde-build-metadata/logical-module-
structure metadata (this is used by kdesrc-build and the CI). This is much
more annoying than a simple lookup but there are at least a couple of tools in
kde-build-metadata that can be used to help.

I believe i18n tracks the 'unstable' and 'stable' branches for each module and
'unstable' might mean "KF5" by now. This information *is* available with the
project data directly. But maybe Albert or Luigi could better explain how the
i18n infra is setup and what we can conclude from these variables.

Regards,
- Michael Pyne

Re: Updating our tools

By Luigi Toscano at 08/09/2015 - 09:56

Michael Pyne ha scritto:
We track four branches (information available from kde_projects.xml):
stable/kdelibs4
trunk/kdelibs4
stable/kf5
trunk/kf5

We don't use them directly, but we keep our metadata in sync with them. Yes,
that could be done in better way; but we can't consume the information
directly from projects.k.o because a wrong/outdated information leads to
wrongly tracked messages (and maintainer sometime forget to update them).

Ciao

Re: Updating our tools

By Albert Astals Cid at 08/09/2015 - 10:05

El Diumenge, 9 d'agost de 2015, a les 16:56:04, Luigi Toscano va escriure:
So if trunk/kf5 you can assume the project has at least a KF5 branch (and you
can get if it's master or some other branch).

Should be ok-ish for the ebn probably.

Cheers,
Albert

Re: Updating our tools

By Allen Winter at 08/09/2015 - 09:45

On Sunday, August 09, 2015 09:58:26 AM Allen Winter wrote:

Re: Updating our tools

By Allen Winter at 08/10/2015 - 18:48

On Sunday, August 09, 2015 10:45:19 AM Allen Winter wrote:
I modified Krazy to look in the project's top-level CMakeLists.txt to determine if its a KDE4 or KF5 project.
Hope this works. Let me know otherwise.

No more hard-coding KF5 projects. yay

-Allen