DevHeads.net

possible ABI break in frameworks

The commit:

<a href="https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1" title="https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1">https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255...</a>

results in apparently public symbols going missing

<a href="https://paste.kde.org/pj1kbp9un" title="https://paste.kde.org/pj1kbp9un">https://paste.kde.org/pj1kbp9un</a>

From IRC.

[08:43] <acheronuk> sitter: does this break ABI in frameworks?
<a href="https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1" title="https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1">https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255...</a>
[08:45] <acheronuk> sitter: <a href="https://paste.kde.org/pj1kbp9un" title="https://paste.kde.org/pj1kbp9un">https://paste.kde.org/pj1kbp9un</a>
[08:59] <sitter> acheronuk: assuming activitiesmodel is in fact a public
class: yes
[08:59] <sitter> adding a const anywhere changes the call signature
[08:59] <sitter>
<a href="https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B" title="https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B">https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B</a>
[09:00] <sitter> You cannot...For existing functions of any type:change
its signature. This includes:changing any of the types of the arguments
in the parameter list, including changing the const/volatile qualifiers
of the existing parameters (instead, add a new method)

Confirmation that this is either an issue that needs to be sorted, or
one where there is no impact is appreciated.

Rik Mills

Comments

Re: possible ABI break in frameworks

By Rik Mills at 05/30/2018 - 07:23

Apologies. I did not see the discussion on kde-frameworks-devel, or the
revert. Sorry for the noise.