DevHeads.net

How should I coordinate the package updates with you guys?

Brotli apparently just got a new update, and I was told I have to
coordinate package updates with you guys in Rawhide instead of just
uploading the updates unannounced. How should I proceed?

Comments

Re: How should I coordinate the package updates with you guys?

By Jason L Tibbitts III at 04/12/2018 - 16:43

Well, there's only really a need to coordinate if the versioning of the
library changes, or if there's an ABI change and (boo) upstream doesn't
bother to bump the soversion when they break the ABI, or if there's
something else that people need to know about like an API change which
is going to break users of the library when they next rebuild.

If you're just releasing a compatible update, then there's no real need
to say much of anything. Otherwise this list would be flooded with
update notices.

If you do need to make an announcement, you should say what is changing,
what needs to be done to accommodate it, and provide a list of packages
which will need rebuilding. You can use the find-package-maintainers
script from
<a href="https://pagure.io/fedora-misc-package-utilities/blob/master/f/find-package-maintainers" title="https://pagure.io/fedora-misc-package-utilities/blob/master/f/find-package-maintainers">https://pagure.io/fedora-misc-package-utilities/blob/master/f/find-packa...</a>
to give a nice list of packages and their owners so that people can
easily see if they'll need to do anything.

(This really needs to be put into the wiki if it isn't already there.)

- J<

Re: How should I coordinate the package updates with you guys?

By Pouar at 04/12/2018 - 18:06

On Thu, 12 Apr 2018 15:43:28 -0500

How do I find out what packages depends on it? Would
`dnf repoquery --whatrequires brotli`
provide that? or is there a different command that I should run? Do I just
make an announcement after uploading with the list of packages that need to
rebuild or is there something else that I need to do first?

Re: How should I coordinate the package updates with you guys?

By Adam Williamson at 04/13/2018 - 12:29

On Thu, 2018-04-12 at 17:06 -0500, <a href="mailto: ... at pouar dot net"> ... at pouar dot net</a> wrote:
No, not quite.

Well, the script above. But you can also do:

dnf repoquery --releasever=rawhide --refresh --whatrequires "libbrotlicommon.so.1()(64bit)"
dnf repoquery --releasever=rawhide --refresh --whatrequires "libbrotlidec.so.1()(64bit)"
dnf repoquery --releasever=rawhide --refresh --whatrequires "libbrotlienc.so.1()(64bit)"

to find *binary* packages with an auto-generated dependency on
the current sonames provided by the library, and:

dnf repoquery --releasever=rawhide --disablerepo=* --enablerepo=fedora-source --whatrequires brotli-devel

to find all source packages that BuildRequire brotli-devel.

Read the URL Fabio linked to, but the important thing is, you need to
do the announcement *well in advance* of doing the actual build, and
ideally come up with a plan for making sure the builds of the
dependencies happen on the same day as the build of brotli.

Note this is all assuming the new version will actually change the
soname - if it doesn't, there's no problem. The current soname in
Rawhide is 'libbrotli(whatever).so.1', if that's the same with the new
version, all existing packages should continue to work with it without
needing to be rebuilt.

Thanks!

Re: How should I coordinate the package updates with you guys?

By Pouar at 04/13/2018 - 16:41

On Fri, 13 Apr 2018 09:29:56 -0700

Not sure how to interpret the example email `packagename-owner@alias`. Would
that be like `brotli- ... at fedoraproject dot org` or ` ... at fedoraproject dot org`
or something else? Is `fedoraproject.org` the right domain for `alias`?

Re: How should I coordinate the package updates with you guys?

By Mathieu Bridon at 04/13/2018 - 16:58

On Fri, 2018-04-13 at 15:41 -0500, <a href="mailto: ... at pouar dot net"> ... at pouar dot net</a> wrote:
It's ${srpmname}- ... at fedoraproject dot org, so in your case:

<a href="mailto:brotli- ... at fedoraproject dot org">brotli- ... at fedoraproject dot org</a>

Re: How should I coordinate the package updates with you guys?

By Pouar at 04/13/2018 - 17:42

On Fri, 13 Apr 2018 22:58:58 +0200

One last question, do I need to list the whatrequires recursively and email
those maintainers as well or just list the immediate whatrequires and
just email those guys?

Re: How should I coordinate the package updates with you guys?

By Adam Williamson at 04/13/2018 - 19:09

On Fri, 2018-04-13 at 16:42 -0500, <a href="mailto: ... at pouar dot net"> ... at pouar dot net</a> wrote:
Just the immediate ones.

Re: How should I coordinate the package updates with you guys?

By Fabio Valentini at 04/13/2018 - 04:18

I suggest you look at the wiki page describing the package update process,
specifically the section for rawhide:

<a href="https://fedoraproject.org/wiki/Updates_Policy#Rawhide_.2F_devel_.2F_master" title="https://fedoraproject.org/wiki/Updates_Policy#Rawhide_.2F_devel_.2F_master">https://fedoraproject.org/wiki/Updates_Policy#Rawhide_.2F_devel_.2F_master</a>

It outlines the actions recommended / needed for updates with and without
implications for dependent packages.

Jason already posted a link to a script which you can use to determine
affected packages and their maintainers.

Fabio