DevHeads.net

Removal of glibc-langpacks-all -> 1.0?kB

Hi all,

One of my package builds (fwupd) in F30 is failing in the unit tests,
with this failure comparing the expected output of a to_string()
function:

- Size: 1.0 kB
+ Size: 1.0?kB

I assume it's due to the removal of glibc-langpacks-all from the
buildroot. I'ts not immediately obvious from reading
<a href="https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot" title="https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot">https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_b...</a>
and <a href="https://fedoraproject.org/w/index.php?title=Changes/Remove_glibc-langpacks-all_from_buildroot" title="https://fedoraproject.org/w/index.php?title=Changes/Remove_glibc-langpacks-all_from_buildroot">https://fedoraproject.org/w/index.php?title=Changes/Remove_glibc-langpac...</a>
what I'm supposed to do. I guess adding back glibc-langpacks-all is
the obvious thing, but I probably only really need en_US.UTF-8 -- I
think. I was surprised C.UTF-8 didn't work. Advice welcome, thanks.

Richard

Comments

Re: Removal of glibc-langpacks-all -> 1.0?kB

By TASAKA Mamoru at 02/02/2019 - 04:31

Richard Hughes wrote on 2019/02/02 17:11:
It may be wrong, however as fwupd-1.2.4 uses g_format_size(), I guess that
this failure is due to recent g_format_size() output change (in glib2-2.59.X):

<a href="https://gitlab.gnome.org/GNOME/glib/commit/76af5dabb4a25956a6c41a75c0c7feeee74496da" title="https://gitlab.gnome.org/GNOME/glib/commit/76af5dabb4a25956a6c41a75c0c7feeee74496da">https://gitlab.gnome.org/GNOME/glib/commit/76af5dabb4a25956a6c41a75c0c7f...</a>
<a href="https://gitlab.gnome.org/GNOME/glib/commit/3aa8b4eba72d0faa57e6bc8727f4f3bab0c2b469" title="https://gitlab.gnome.org/GNOME/glib/commit/3aa8b4eba72d0faa57e6bc8727f4f3bab0c2b469">https://gitlab.gnome.org/GNOME/glib/commit/3aa8b4eba72d0faa57e6bc8727f4f...</a>

i.e. g_format_size() now returns string like "1.0<nbsp>kB", not "1.0<space>kB".

Regards,
Mamoru

Re: Removal of glibc-langpacks-all -> 1.0?kB

By Richard Hughes at 02/02/2019 - 06:43

On Sat, 2 Feb 2019 at 10:29, Mamoru TASAKA < ... at fedoraproject dot org> wrote:
Aha! Thanks, that sounds exactly right. Much appreciated.

Richard.

Re: Removal of glibc-langpacks-all -> 1.0?kB

By Florian Weimer at 02/02/2019 - 06:37

* Mamoru TASAKA:

Do you know what performs the incorrect transliteration here? In
C.UTF-8, <nbsp> can certainly be used, and even in ASCII, <space> is
probably the better transliteration.

Thanks,
Florian

Re: Removal of glibc-langpacks-all -> 1.0?kB

By TASAKA Mamoru at 02/02/2019 - 07:10

Florian Weimer wrote on 2019/02/02 20:37:
Well, I don't know well.. So what fwupd seems to be doing here is like:

$ echo -e "1.0\xc2\xa0kB" > a.txt
$ echo -e "1.0 kB" > b.txt
$ diff -uNp a.txt b.txt

and my console (gnome-terminal) says:

--- a.txt 2019-02-02 21:03:43.855731848 +0900
+++ b.txt 2019-02-02 21:03:50.462725614 +0900
@@ -1 +1 @@
-1.0 kB
+1.0 kB

So actually it "differs", but it does not show "?" character. (But currently
I tried the above on F-29, not F-30).

Regards,
Mamoru

Re: Removal of glibc-langpacks-all -> 1.0?kB

By Florian Weimer at 02/02/2019 - 09:04

* Mamoru TASAKA:

I'm not concerned about the NBSP character. The transliteration to ?
worries me. This looks like something we need to fix, but I don't know
if that needs to happen in glib2 or glibc.

Thanks,
Florian