DevHeads.net

Review swaps

Hi all,

Sagemath 8.6 is out, which means that at long last we can upgrade the
gap package. Upgrading gap means dealing with the fact that some of
the fundamental group libraries have now been split out of the main
package and have their own upstream repositories. That means that I
need reviews for 3 packages that are based on a version of gap that
hasn't been built in Rawhide yet:

gap-pkg-primgrp: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1672861" title="https://bugzilla.redhat.com/show_bug.cgi?id=1672861">https://bugzilla.redhat.com/show_bug.cgi?id=1672861</a>
gap-pkg-smallgrp: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1672862" title="https://bugzilla.redhat.com/show_bug.cgi?id=1672862">https://bugzilla.redhat.com/show_bug.cgi?id=1672862</a>
gap-pkg-transgrp: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1672863" title="https://bugzilla.redhat.com/show_bug.cgi?id=1672863">https://bugzilla.redhat.com/show_bug.cgi?id=1672863</a>

The necessary prerequisite packages, as well as the packages needing
review, can be found here:

<a href="https://copr.fedorainfracloud.org/coprs/jjames/GAP/" title="https://copr.fedorainfracloud.org/coprs/jjames/GAP/">https://copr.fedorainfracloud.org/coprs/jjames/GAP/</a>

I am willing to swap reviews. Let me know what you would like me to
review in exchange. Thank you,

Comments

Re: Review swaps

By Jerry James at 02/13/2019 - 23:51

On Tue, Feb 5, 2019 at 9:22 PM Jerry James < ... at gmail dot com> wrote:
I still need one or more reviewers for these packages. I know Mufti
volunteered to review them if I sponsor him, but I think it will take
just a little longer before he is ready to do official reviews. In
the meantime, this is holding up the upgrades to GAP 4.10.0 and
sagemath 8.6. Who out there needs a review done? I'll swap with you.
Thanks,

Re: Review swaps

By Jared K. Smith at 02/14/2019 - 11:08

I'm reviewing them now, and will respond with two that I'd like you to
review after I'm done.

-Jared

Re: Review swaps

By Jerry James at 02/14/2019 - 18:54

On Thu, Feb 14, 2019 at 8:09 AM Jared K. Smith < ... at fedoraproject dot org> wrote:
Thank you, Jared! Much appreciated.

Re: Review swaps

By Jared K. Smith at 02/15/2019 - 14:25

OK, I think your packages all have reviews now. Would you be willing to do
these two in return? They're both re-reviews of previously approved but
then retired NodeJS packages.

nodejs-is-plain-obj: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1676540" title="https://bugzilla.redhat.com/show_bug.cgi?id=1676540">https://bugzilla.redhat.com/show_bug.cgi?id=1676540</a>
nodejs-event-stream: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1676544" title="https://bugzilla.redhat.com/show_bug.cgi?id=1676544">https://bugzilla.redhat.com/show_bug.cgi?id=1676544</a>

-Jared

Re: Review swaps

By Tom Hughes at 02/15/2019 - 14:35

I've already done those two...

Tom

On 15/02/2019 18:25, Jared K. Smith wrote:

Re: Review swaps

By Jerry James at 02/15/2019 - 15:19

On Fri, Feb 15, 2019 at 11:36 AM Tom Hughes < ... at compton dot nu> wrote:
Well, then, I owe Jared some reviews. Jared, give me a yell the next
time you have packages that need to be reviewed. I'll try to beat Tom
to them next time. :-)

Regards,