DevHeads.net

Reviewing a package with an rpmfusion dependency

I was just looking at reviewing this package:

<a href="https://bugzilla.redhat.com/show_bug.cgi?id=1684950" title="https://bugzilla.redhat.com/show_bug.cgi?id=1684950">https://bugzilla.redhat.com/show_bug.cgi?id=1684950</a>

It is a Go wrapper around ffprobe, which is in the ffmpeg package,
which is in rpmfusion-free. The package can be built without ffprobe,
but cannot be used without it. The spec file contains this:

# We can't have a hard dependency because patents
Recommends: ffmpeg

Really, this package should have "Requires: ffmpeg", because it cannot
be used at all without ffprobe. So I think this package should not be
in Fedora, but in rpmfusion instead, and that the review request
should be denied.

Thoughts?

Comments

Re: Reviewing a package with an rpmfusion dependency

By Bob Mauchin at 03/15/2019 - 00:16

On vendredi 15 mars 2019 04:53:39 CET Jerry James wrote:
That library is needed by golang-github-anacrolix-dms, which states:

dms uses ffprobe/avprobe to get media data such as bitrate and duration,
ffmpeg/avconv for video transoding, and ffmpegthumbnailer for generating
thumbnails when browsing. These commands must be in the PATH given to dms
**or the features requiring them will be disabled.**

So the dependency to ffprobe is optional: some of the functionalities will be
available but not all.

All of these packages are dependencies to Rclone 1.46 which needs to be
updated in Fedora.