DevHeads.net

Reviewing a package with an rpmfusion dependency

I was just looking at reviewing this package:

<a href="https://bugzilla.redhat.com/show_bug.cgi?id=1684950" title="https://bugzilla.redhat.com/show_bug.cgi?id=1684950">https://bugzilla.redhat.com/show_bug.cgi?id=1684950</a>

It is a Go wrapper around ffprobe, which is in the ffmpeg package,
which is in rpmfusion-free. The package can be built without ffprobe,
but cannot be used without it. The spec file contains this:

# We can't have a hard dependency because patents
Recommends: ffmpeg

Really, this package should have "Requires: ffmpeg", because it cannot
be used at all without ffprobe. So I think this package should not be
in Fedora, but in rpmfusion instead, and that the review request
should be denied.

Thoughts?

Comments

Re: Reviewing a package with an rpmfusion dependency

By =?ISO-8859-1?Q?... at 03/18/2019 - 12:14

On Thu, 2019-03-14 at 21:53 -0600, Jerry James wrote:
Some time ago it was forbidden by package guidelines , packages that
depends exclusively on 3rd party repos , now I'm not sure .

Re: Reviewing a package with an rpmfusion dependency

By Ben Rosser at 03/18/2019 - 12:29

On Mon, Mar 18, 2019 at 12:15 PM Sérgio Basto < ... at serjux dot com> wrote:
I seem to recall this was discussed more recently in the context of
weak dependencies. I think the conclusion was that Fedora packages
*cannot* (or at least, should not) have weak deps on non-Fedora
packages and that instead non-Fedora packages should use reverse weak
deps (Supplements/Enhances).

The problem, though, is that this would mean the ffmpeg package would
end up with a long list of reverse weak deps. And the maintainers of
ffmpeg in RPM Fusion were-- reasonably, I think-- not so eager to
maintain such a list. I don't remember if a resolution was reached
here. But I think the difficulty is that you can't rely on ffmpeg
being provided by RPM Fusion, because users could have a
non-RPM-Fusion repository on their system that provides ffmpeg, so if
could be dangerous to make assumptions about what the "ffmpeg" package
actually is?

Cheers,
Ben Rosser

Re: Reviewing a package with an rpmfusion dependency

By Bob Mauchin at 03/15/2019 - 00:16

On vendredi 15 mars 2019 04:53:39 CET Jerry James wrote:
That library is needed by golang-github-anacrolix-dms, which states:

dms uses ffprobe/avprobe to get media data such as bitrate and duration,
ffmpeg/avconv for video transoding, and ffmpegthumbnailer for generating
thumbnails when browsing. These commands must be in the PATH given to dms
**or the features requiring them will be disabled.**

So the dependency to ffprobe is optional: some of the functionalities will be
available but not all.

All of these packages are dependencies to Rclone 1.46 which needs to be
updated in Fedora.