state of fedora-review?


I am wondering about the state of the "fedora-review" package. It seems to be
a pretty important package to ensure new stuff adhers to the latest Fedora
packaging policy.

When I ran "fedora-review" I noticed that it was clearly not updated for some
time: There where outdated points about bundled libraries (nowadays without
special FPC exception), a warning about an unnecessary "gcc" build requirement
and many outdated links.

Well, it turns out fedora-review fails to build from source since July 2018
[3] (last successful koji build was in March 2018). I think at least some
things are fixed upstream [4] but the RPM package was never updated.

Is fedora-review still the preferred tool to do package reviews?

In the last weeks I spent a bit of time checking the review requests for hcc
[1] and hip [2] which form an important part of AMD's "rocm" stack. These
packages are "special snowflakes" in a sense that they are compilers/compiler
wrappers with all the shenanigans this involves (bundled llvm, explicit lib
dependencies, even dependencies on static libraries).

Approving these libraries would require ignoring quite a few rpmlint
errors/warnings and I don't feel confident in doing so if the fedora-review
tool is obviously outdated.
(Btw: I'd highly appreciate if someone could look at the hcc/hip review
requests. These packages would enable "open source machine learning" in Fedora
and IMHO that area fits Fedora's mission pretty well.)

Thank you very much,

[1] <a href="" title=""></a>
[2] <a href="" title=""></a>
[3] <a href="" title=""></a>
[4] <a href="" title=""></a>


Re: state of fedora-review?

By King InuYasha at 03/03/2019 - 19:16

On Sun, Mar 3, 2019 at 6:14 PM Felix Schwarz < ... at fedoraproject dot org> wrote:
It is still preferred. I was hoping that the in-progress Python 3
porting PR[1] would land first, but I guess I'll have to push a Git
snapshot release in...

I don't want to make a new release without Python 3 support.

[1]: <a href="" title=""></a>

Re: state of fedora-review?

By Bob Mauchin at 03/03/2019 - 20:48

On lundi 4 mars 2019 00:16:02 CET Neal Gompa wrote:

I've got a COPR based on the devel branch:

<a href="" title=""></a>

Re: state of fedora-review?

By King InuYasha at 03/17/2019 - 15:43

On Sun, Mar 3, 2019 at 7:48 PM Robert-André Mauchin <zebob. ... at gmail dot com> wrote:
fedora-review 0.7.0 has been released and updates have been proposed for Fedora:

Fedora 30: <a href="" title=""></a>
Fedora 29: <a href="" title=""></a>
Fedora 28: <a href="" title=""></a>

Hopefully now it'll be easier to respond and release fixes going forward...