DevHeads.net

Taskotron test failures (dist.rpmlint)

Hello,

I've just submitted an update to cmpfit[0] for f28. The automated tests
show errors and warnings only on x86_64 and armv7hl[1] and the errors have
to do with the omission of ldconfig scriptlets. Aren't we supposed to get
rid of these for f28+?

The warnings are:
cmpfit-devel.armv7hl: W: no-documentation
cmpfit-devel.x86_64: W: only-non-binary-in-usr-lib
cmpfit-devel.x86_64: W: no-documentation
Is there any merit to them? Do I need to move or copy the README from the
main package to cmpfit-devel?

There is also this message:
"/usr/bin/python: can't open file '/usr/lib/rpm/python-macro-helper':
[Errno 2] No such file or directory"
I had encountered this in the past with some other updates, but I was under
the impression that it was fixed[2].

I was also under the impression that an edit to the update would cause all
tests to be run again, so I added some stuff to the description, but
according to bodhi, the only test that got rerun was dist.rpmdeplint.

I should note that when I built the packages and ran tests on them in mock
for f28 and rawhide there were no errors or warnings.

Could someone please take a look and tell me if I need to fix something?

Thank you,
Alex

0. <a href="https://bodhi.fedoraproject.org/updates/cmpfit-1.3a-1.fc28" title="https://bodhi.fedoraproject.org/updates/cmpfit-1.3a-1.fc28">https://bodhi.fedoraproject.org/updates/cmpfit-1.3a-1.fc28</a>
1.
<a href="https://taskotron.fedoraproject.org/artifacts/all/1129fb0c-568c-11e8-87d4-525400fc9f92/tests.yml/cmpfit-1.3a-1.fc28.log" title="https://taskotron.fedoraproject.org/artifacts/all/1129fb0c-568c-11e8-87d4-525400fc9f92/tests.yml/cmpfit-1.3a-1.fc28.log">https://taskotron.fedoraproject.org/artifacts/all/1129fb0c-568c-11e8-87d...</a>
2. <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1535692" title="https://bugzilla.redhat.com/show_bug.cgi?id=1535692">https://bugzilla.redhat.com/show_bug.cgi?id=1535692</a>

Comments

Re: Taskotron test failures (dist.rpmlint)

By Jason L Tibbitts III at 05/14/2018 - 13:46

AP> /usr/bin/python: can't open file '/usr/lib/rpm/python-macro-helper':
AP> [Errno 2] No such file or directory

For the record, this happens because rpmlint does the equivalent of:

rpm -E %python_sitearch

by calling the expandMacro() function from the rpm python bindings. If
you run that without rpm-build installed, rpm itself will produce that
message on stderr. Basically any shell expansion in rpm (using %(...)
can produce stderr output and nothing seems to trap it.

I'm not sure what the best solution is; I did suggest some in the ticket
which was opened (<a href="https://bugzilla.redhat.com/show_bug.cgi?id=1577860" title="https://bugzilla.redhat.com/show_bug.cgi?id=1577860">https://bugzilla.redhat.com/show_bug.cgi?id=1577860</a>).

- J<

Re: Taskotron test failures (dist.rpmlint)

By Kamil Paral at 05/14/2018 - 05:58

On Sun, May 13, 2018 at 12:22 PM, Alexander Ploumistos <

I filed a bug here:
<a href="https://bugzilla.redhat.com/show_bug.cgi?id=1577860" title="https://bugzilla.redhat.com/show_bug.cgi?id=1577860">https://bugzilla.redhat.com/show_bug.cgi?id=1577860</a>

I'll also make sure the task will install rpm-build until this is fixed.

rpmdeplint gets retested periodically. Which tests do you need to re-run?
rpmlint runs each time a Koji build is completed, and can't be re-executed
at the moment (but it would provide the same results anyway). Updating the
Bodhi update would re-trigger some tests, yes, but you'd have to add/remove
builds to/from it.

Running rpmlint locally should provide the same results. We're simply
running the tool, and adding a config file if present in distgit:
<a href="https://fedoraproject.org/wiki/Taskotron/Tasks/dist.rpmlint" title="https://fedoraproject.org/wiki/Taskotron/Tasks/dist.rpmlint">https://fedoraproject.org/wiki/Taskotron/Tasks/dist.rpmlint</a>

Re: Taskotron test failures (dist.rpmlint)

By Alexander Ploumistos at 05/14/2018 - 07:39

Thanks Kamil.

Well, rpmlint is the one that failed and only on two arches, that's why I
wanted it to be run again, just in case something was off the first time. I
thought that if library-without-ldconfig-postin were a valid error, it
should appear on all arches.

Using rpmlint-1.10-12.fc28 on the source rpm and e.g. all the x86_64 rpms I
only get this warning:
cmpfit-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 1 warnings.

Re: Taskotron test failures (dist.rpmlint)

By Kamil Paral at 05/15/2018 - 03:31

On Mon, May 14, 2018 at 1:39 PM, Alexander Ploumistos <

We only run it for primary arches, so it did appear on all. I'll try to
make it clearer in the log.

For some reason rpmlint-1.10-7.fc28.noarch was used. I'll investigate.