DevHeads.net

Why does anaconda-core runtime depend on python3-coverage?

Hey, I have noticed that anaconda-core has a runtime dependency on python3-coverage.

Is it some weird error, or does anaconda actually need a test coverage measuring
tool at runtime?

Thanks,

Comments

Re: Why does anaconda-core runtime depend on python3-coverage?

By Brian C. Lane at 08/12/2019 - 11:33

On Sun, Aug 11, 2019 at 11:39:34AM +0200, Miro HronĨok wrote:
Yes. If you pass inst.debug=1 it will generate a coverage report.

<a href="https://github.com/rhinstaller/anaconda/blob/master/anaconda.py#L35" title="https://github.com/rhinstaller/anaconda/blob/master/anaconda.py#L35">https://github.com/rhinstaller/anaconda/blob/master/anaconda.py#L35</a>

Re: Why does anaconda-core runtime depend on python3-coverage?

By Igor Gnatenko at 08/12/2019 - 13:44

What is the point of this? I am probably missing something obvious..

Re: Why does anaconda-core runtime depend on python3-coverage?

By Brian C. Lane at 08/14/2019 - 13:29

On Mon, Aug 12, 2019 at 08:44:24PM +0200, Igor Gnatenko wrote:
I think this was because getting good coverage data from anaconda
without actually booting the installer iso wasn't possible. atodorov may
be able to provide more context.

Re: Why does anaconda-core runtime depend on python3-coverage?

By Adam Williamson at 08/14/2019 - 13:47

On Wed, 2019-08-14 at 11:29 -0700, Brian C. Lane wrote:
was this possibly to do with the kickstart-tests effort - an attempt to
figure out the code coverage of those tests?

Re: Why does anaconda-core runtime depend on python3-coverage?

By =?UTF-8?Q?Ji=C5... at 08/16/2019 - 05:36

The coverage dependency was removed (F31 and Rawhide):

<a href="https://github.com/rhinstaller/anaconda/pull/2086" title="https://github.com/rhinstaller/anaconda/pull/2086">https://github.com/rhinstaller/anaconda/pull/2086</a>

The main reason for the removal was that this wasn't really used in the
past and the recent Anaconda changes needs other solution to get the
correct coverage.

Jirka

On Wed, 2019-08-14 at 11:47 -0700, Adam Williamson wrote: