DevHeads.net

Postings by David Jarvie

Review Request 127629: Fix KDateTime::isValid() for ClockTime values

Review request for kdelibs.

Bugs: 336738
<a href="https://bugs.kde.org/show_bug.cgi?id=336738" title="https://bugs.kde.org/show_bug.cgi?id=336738">https://bugs.kde.org/show_bug.cgi?id=336738</a>

Repository: kdelibs4support

Description
KDateTime::isValid() wrongly returns invalid for an instance which is specified in ClockTime, if the date/time is invalid in the local time zone.

Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

Review request for kdelibs.

Repository: kdelibs

Description
When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string.

Re: Compiler version

On Monday 02 July 2012 09:09:53 Ivan Cukic wrote:
Not in all cases - I use Debian stable (although I'll probably update to testing quite soon).

Review Request: Fix wrong time zone abbreviation being returned for early dates

Review request for kdelibs.

Description
KTzfileTimeZone, and therefore time zones provided by KSystemTimeZones, returns the wrong time zone abbreviation for dates earlier than the start of time zone data in the time zone configuration file. This patch fixes that, but requires a new variant of the setPhases() method to be added to KTimeZone.

Review Request: Limit KDateComboBox date keywords to the date range set for the widget

Review request for kdelibs and John Layt.

Description
Currently, all configured date keywords are displayed in the date picker popup, including keywords for dates which lie outside the set date range and which are therefore invalid for selection. This patch hides keywords for dates earlier than the minimum date, or later than the maximum date.

Review Request: Fix KStatusNotifierItem not updating its icon when set by pixmap

Review request for kdelibs and Marco Martin.

Description
Set the icon for KStatusNotifierItem by setIconByPixmap(), then by setIconByName(). If setIconByPixmap() is called to set the first icon again, the icon doesn't change.

Review Request: Fix KDateComboBox shrinking in size after a date is entered

Review request for kdelibs and John Layt.

Description
After the user enters a date by means of the date picker or by up/down arrows, the edit field in KDateComboBox shrinks so that it is too small to display all the characters in the date. In addition, when first displayed, the widget visibly resizes, which doesn't look particularly good.

Review Request: Provide extra options for date keyword display in KDateComboBox

Review request for kdelibs and John Layt.

Description
KDateComboBox provides the option to display a list of date keywords with the date picker popup. These keywords currently show dates in the past, present and future, together with a "no date" item.

Review Request: Prevent KMessageBox instances with a parent from being application modal

Review request for kdelibs.

Summary
According to the apidocs, KMessageBox instances with a parent widget specified are supposed to be window modal, not application modal.

Locating executables in root's PATH (in KAuth helper)

Is there any KDE or Qt way to locate an executable using the root PATH. Specifically, I want to run something which on my system is in /usr/sbin/, calling it from a KAuth helper module running as root. KStandarDirs::findExe() doesn't produce any result (the PATH variable doesn't seem to be set up). I could hard code the /usr/sbin/ path, but that doesn't seem desirable in case the executable is elsewhere on some systems.

Review Request: Fix KAuth::Action::execute() not returning error description string

Review request for kdelibs and Dario Freddi.

Summary
KAuth::Action::execute() doesn't return the error description string contained in KAuth::ActionReply. The reason is that the errorDescription() is not serialized by operator>>() or operator<<().

kdesupport for 4.6

There doesn't seem to be a kdesupport package in git or svn for use with KDE 4.6, equivalent to the svn tag kdesupport-for-4.5 for KDE 4.5. Are there plans to create this?