Git commit 81bc7c68537639a739d0f89f7777103a1c26b61d by Ben Cooksley.
Committed on 29/11/2019 at 18:49.
Pushed by bcooksley into branch 'master'.

Move KQuickCharts into Frameworks.

Ref T12022

CCMAIL: <a href="mailto:kde-frameworks- ... at kde dot org">kde-frameworks- ... at kde dot org</a>
CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>

R +0 -0 projects/frameworks/kquickcharts/i18n.json [from: projects/kdereview/kquickcharts/i18n.json - 100% similarity]
R +1 -1 projects/frameworks/kquickcharts/metadata.yaml [from: projects/kdereview/kquickcharts/metadata.yaml - 084% similarity]

<a href="https://commits.kde.org/sysadmin/repo-metadata/81bc7c68537639a739d0f89f77771" title="https://commits.kde.org/sysadmin/repo-metadata/81bc7c68537639a739d0f89f77771">https://commits.kde.org/sysadmin/repo-metadata/81bc7c68537639a739d0f89f7...</a>

Git commit ad16c293e8a0caf000157d4a1a589515ddc0f2e4 by Ben Cooksley.
Committed on 12/09/2019 at 06:32.
Pushed by bcooksley into branch 'master'.

Move Ruqola to KDE Review per the request of Laurent Montel.

CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>

R +0 -0 projects/kdereview/ruqola/i18n.json [from: projects/playground/network/ruqola/i18n.json - 100% similarity]
R +1 -1 projects/kdereview/ruqola/metadata.yaml [from: projects/playground/network/ruqola/metadata.yaml - 084% similarity]

<a href="https://commits.kde.org/sysadmin/repo-metadata/ad16c293e8a0caf000157d4a1a589515ddc0f2e4" title="https://commits.kde.org/sysadmin/repo-metadata/ad16c293e8a0caf000157d4a1a589515ddc0f2e4">https://commits.kde.org/sysadmin/repo-metadata/ad16c293e8a0caf000157d4a1...</a>

diff --git a/proje

Git commit f271a43036c1c2b1ab4c328af6ebde7d92b7f5a5 by Ben Cooksley.
Committed on 03/09/2019 at 17:47.
Pushed by bcooksley into branch 'master'.

Ensure that we setup QT_DATA_DIRS on Windows & MacOS.
While not an upstream option, it is one supported by the Craft patched Qt (which we use on Windows & MacOS) so we're going to rely on this.

CCMAIL: <a href="mailto: ... at kde dot org"> ... at kde dot org</a>
CCMAIL: <a href="mailto:kde- ... at kde dot org">kde- ... at kde dot org</a>

M +7 -0 helpers/helperslib/EnvironmentHandler.py

<a href="https://invent.kde.org/sysadmin/ci-tooling/commit/f271a43036c1c2b1ab4c328af6ebde7d92b7f5a5" title="https://invent.kde.org/sysadmin/ci-tooling/commit/f271a43036c1c2b1ab4c328af6ebde7d92b7f5a5">https://invent.kde.org/sysadmin/ci-tooling/commit/f271a43036c1c2b1ab4c32...</a>

diff --git a/helpers/helperslib/EnvironmentHandler.py b/hel

Git commit d8cc2c16711a48ed470a04a92b96388a65467091 by David Faure.
Committed on 03/09/2019 at 09:13.
Pushed by dfaure into branch 'master'.

autotests: check that mimetypes defined by kcoreaddons are available

Clearly they are not, on Windows, in CI (this commit just makes the error
clearer).

Was a solution found for the problem of finding mimetypes (using
GenericDataLocation) in custom prefixes?

Git commit 7f8a8320827041cbd9f95d42d6309f3fd12e5fef by Ben Cooksley.
Committed on 15/06/2019 at 21:15.
Pushed by bcooksley into branch 'master'.

Enable MSVC (64 Bit) builds for RKWard as requested.

CCMAIL: <a href="mailto:thomas.friedrichsmeier@ruhr-uni-bochum.de">thomas.friedrichsmeier@ruhr-uni-bochum.de</a>
CCMAIL: <a href="mailto:rkward- ... at kde dot org">rkward- ... at kde dot org</a>
CCMAIL: <a href="mailto:kde- ... at kde dot org">kde- ... at kde dot org</a>

M +7 -0 craft/enabled-projects.yaml

<a href="https://invent.kde.org/sysadmin/binary-factory-tooling/commit/7f8a8320827041cbd9f95d42d6309f3fd12e5fef" title="https://invent.kde.org/sysadmin/binary-factory-tooling/commit/7f8a8320827041cbd9f95d42d6309f3fd12e5fef">https://invent.kde.org/sysadmin/binary-factory-tooling/commit/7f8a832082...</a>

diff --git a/craft/enabled-projects.yaml b/craft/enabled-projects.yaml
index d2a6662..f8e5dcb 100644
--- a/craft/enabled-projects.yaml
+++ b/c

Git commit 4a81f737b5926a1c2f7b63e4640c4e25585b2260 by Ben Cooksley.
Committed on 08/02/2019 at 07:53.
Pushed by bcooksley into branch 'master'.

Move plasma-pass to Extragear as requested by it's maintainer following the completion of the review.

Fixes T10453

CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>

R +0 -0 projects/extragear/base/plasma-pass/i18n.json [from: projects/kdereview/plasma-pass/i18n.json - 100% similarity]
R +1 -1 projects/extragear/base/plasma-pass/metadata.yaml [from: projects/kdereview/plasma-pass/metadata.yaml - 084% similarity]

<a href="https://commits.kde.org/sysadmin/repo-me" title="https://commits.kde.org/sysadmin/repo-me">https://commits.kde.org/sysadmin/repo-me</a>

Git commit 045ad2dee96281a9b2b97df31f3635f5e897fa05 by Ben Cooksley.
Committed on 05/10/2018 at 23:01.
Pushed by bcooksley into branch 'master'.

Move RKWard to KDE Review per their request.

Ref T9804

CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>

R +0 -0 projects/kdereview/rkward/i18n.json [from: projects/playground/edu/rkward/i18n.json - 100% similarity]
R +1 -1 projects/kdereview/rkward/metadata.yaml [from: projects/playground/edu/rkward/metadata.yaml - 091% similarity]

<a href="https://commits.kde.org/sysadmin/repo-metadata/045ad2dee96281a9b2b97df31f3635f5e897fa05" title="https://commits.kde.org/sysadmin/repo-metadata/045ad2dee96281a9b2b97df31f3635f5e897fa05">https://commits.kde.org/sysadmin/repo-metadata/045ad2dee96281a9b2b97df31...</a>

diff --git a/projects/playgroun

Git commit dbf563df2979361e9b97088e757f95315296ea19 by Ben Cooksley.
Committed on 26/02/2018 at 07:19.
Pushed by bcooksley into branch 'master'.

Move Elisa from KDE Review to Extragear - Multimedia as requested.
Ref T8080

CCMAIL: <a href="mailto:release- ... at kde dot org">release- ... at kde dot org</a>
CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>

R +0 -0 projects/extragear/multimedia/elisa/i18n.json [from: projects/kdereview/elisa/i18n.json - 100% similarity]
R +1 -1 projects/extragear/multimedia/elisa/metadata.yaml [from: projects/kdereview/elisa/metadata.yaml - 082% similarity]

<a href="https://commits.kde.org/sysadmin/repo-metadata/dbf563df2979361" title="https://commits.kde.org/sysadmin/repo-metadata/dbf563df2979361">https://commits.kde.org/sysadmin/repo-metadata/dbf563df2979361</a>

Git commit 0ebff8bc19138c04a9b05f808d92c1a6bcfbc620 by Ben Cooksley.
Committed on 05/02/2018 at 08:42.
Pushed by bcooksley into branch 'master'.

Move Elisa to KDE Review per the request of it's maintainer

Fixes T7885

CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>

R +0 -0 projects/kdereview/elisa/i18n.json [from: projects/playground/multimedia/elisa/i18n.json - 100% similarity]
R +1 -1 projects/kdereview/elisa/metadata.yaml [from: projects/playground/multimedia/elisa/metadata.yaml - 082% similarity]

<a href="https://commits.kde.org/sysadmin/repo-metadata/0ebff8bc19138c04a9b05f808d92c1a6bcfbc620" title="https://commits.kde.org/sysadmin/repo-metadata/0ebff8bc19138c04a9b05f808d92c1a6bcfbc620">https://commits.kde.org/sysadmin/repo-metadata/0ebff8bc19138c04a9b05f808...</a>

diff

Git commit 9146d557b5d0c00ef400241736d1bfe564576c81 by Ben Cooksley.
Committed on 05/02/2018 at 08:36.
Pushed by bcooksley into branch 'master'.

Move KBackup to it's new home in KDE Utils.
This application was in KDE Review per the mailing list announcements, it just hadn't been moved in the structure to kdereview/ hence the direct jump here.

Fixes T7881

CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>
CCMAIL: <a href="mailto:release- ... at kde dot org">release- ... at kde dot org</a>

R +0 -0 projects/kde/kdeutils/kbackup/i18n.json [from: projects/playground/base/kbackup/i18n.json - 100% similarity]
R +1 -1 projects/kde/kdeutils/kbackup/metadata.y

Git commit fcd2fd6eb661bec284e08cef9f844843b5696c19 by Ben Cooksley.
Committed on 30/01/2018 at 09:52.
Pushed by bcooksley into branch 'master'.

Move Plasma Mycroft from KDE Review to it's final home at the request of it's maintainer.

Ref T7814

CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>

R +0 -0 projects/extragear/utils/plasma-mycroft/i18n.json [from: projects/kdereview/plasma-mycroft/i18n.json - 100% similarity]
R +1 -1 projects/extragear/utils/plasma-mycroft/metadata.yaml [from: projects/kdereview/plasma-mycroft/metadata.yaml - 086% similarity]

<a href="https://commits.kde.org/sysadmin/repo-met" title="https://commits.kde.org/sysadmin/repo-met">https://commits.kde.org/sysadmin/repo-met</a>

Git commit ce94f3398e4abf08bc5620f8ca7cdaccc5f9371f by Ben Cooksley.
Committed on 24/06/2017 at 02:05.
Pushed by bcooksley into branch 'master'.

Move Atelier and AtCore to KDE Review proper.
CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>
Fixes T6383

R +0 -0 projects/kdereview/atcore/i18n.json [from: projects/playground/base/atcore/i18n.json - 100% similarity]
R +1 -1 projects/kdereview/atcore/metadata.yaml [from: projects/playground/base/atcore/metadata.yaml - 085% similarity]
R +0 -0 projects/kdereview/atelier/i18n.json [from: projects/playground/base/atelier/i18n.json - 100% similarit

Git commit 8464153d3e7b76c37a3114a9c639c17fc07f6e8e by Ben Cooksley.
Committed on 10/06/2017 at 03:36.
Pushed by bcooksley into branch 'master'.

Move QtCurve to KDE Review at request of it's maintainer
CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>
Fixes T6306

R +0 -0 projects/kdereview/qtcurve/i18n.json [from: projects/playground/base/qtcurve/i18n.json - 100% similarity]
R +0 -0 projects/kdereview/qtcurve/metadata.yaml [from: projects/playground/base/qtcurve/metadata.yaml - 100% similarity]

<a href="https://commits.kde.org/sysadmin/repo-metadata/8464153d3e7b76c37a3114a9c639c17fc07f6e8e" title="https://commits.kde.org/sysadmin/repo-metadata/8464153d3e7b76c37a3114a9c639c17fc07f6e8e">https://commits.kde.org/sysadmin/repo-metadata/8464153d3e7b76c37a3114a9c...</a>

diff --git a/

Git commit 866a38766e5c33ef81e9f2434f6d8995bd5f1aea by Ben Cooksley.
Committed on 08/06/2017 at 06:29.
Pushed by bcooksley into branch 'master'.

Move Zanshin to KDE Review.
CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>
Fixes T6277

R +0 -0 projects/kdereview/zanshin/i18n.json [from: projects/playground/pim/zanshin/i18n.json - 100% similarity]
R +1 -1 projects/kdereview/zanshin/metadata.yaml [from: projects/playground/pim/zanshin/metadata.yaml - 089% similarity]

<a href="https://commits.kde.org/sysadmin/repo-metadata/866a38766e5c33ef81e9f2434f6d8995bd5f1aea" title="https://commits.kde.org/sysadmin/repo-metadata/866a38766e5c33ef81e9f2434f6d8995bd5f1aea">https://commits.kde.org/sysadmin/repo-metadata/866a38766e5c33ef81e9f2434...</a>

diff --git a/projects/playground/pim/zanshin

Git commit c52788ab01cf08b359842a44a3213239533d810a by Ben Cooksley.
Committed on 28/04/2017 at 19:15.
Pushed by bcooksley into branch 'master'.

Move plymouth-kcm from KDE Review to Plasma Workspace in the virtual hierarchy after it cleared review last year.
Fixes T5967
CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>
CCMAIL: <a href="mailto:plasma- ... at kde dot org">plasma- ... at kde dot org</a>
CCMAIL: <a href="mailto:release- ... at kde dot org">release- ... at kde dot org</a>

R +0 -0 projects/kde/workspace/plymouth-kcm/i18n.json [from: projects/kdereview/plymouth-kcm/i18n.json - 100% similarity]
R +1 -1 projects/kde/workspace/plymouth-kcm/metadata.yaml [from: projects/kdereview/plymouth-kcm/metad

Git commit 01bc4814fa11272f54e6f33f7a3f3e2ae883913c by Ben Cooksley.
Committed on 27/04/2017 at 09:59.
Pushed by bcooksley into branch 'master'.

Move kdepim-runtime to kde/pim/ in the virtual hierarchy.
WARNING: All projects which depend on kdepim-runtime on the CI system will be broken until kdepim-runtime has been rebuilt following this commit.

Git commit aa20ad09ba818607b9fe173b5bf97ba8f10c310c by Ben Cooksley.
Committed on 24/04/2017 at 20:19.
Pushed by bcooksley into branch 'master'.

Rename imagewriter to usbimagewriter, and move it to Extragear/Utils as requested.
Fixes T5945
CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>

R +0 -0 projects/extragear/utils/usbimagewriter/i18n.json [from: projects/kdereview/imagewriter/i18n.json - 100% similarity]
R +2 -2 projects/extragear/utils/usbimagewriter/metadata.yaml [from: projects/kdereview/imagewriter/metadata.yaml - 081% similarity]

<a href="https://commits.kde.org/sysadmin/repo-metadata/aa20ad0" title="https://commits.kde.org/sysadmin/repo-metadata/aa20ad0">https://commits.kde.org/sysadmin/repo-metadata/aa20ad0</a>

Git commit b8559f750bfa648ebae4a26882b2a64f07ae3094 by Ben Cooksley.
Committed on 07/03/2017 at 06:24.
Pushed by bcooksley into branch 'master'.

Move Plasma Vault to (Plasma) Workspace
Fixes T5335
CCMAIL: <a href="mailto:release- ... at kde dot org">release- ... at kde dot org</a>
CCMAIL: <a href="mailto:kde-core- ... at kde dot org">kde-core- ... at kde dot org</a>
CCMAIL: <a href="mailto:plasma- ... at kde dot org">plasma- ... at kde dot org</a>

R +0 -0 projects/kde/workspace/plasma-vault/i18n.json [from: projects/kdereview/plasma-vault/i18n.json - 100% similarity]
R +1 -1 projects/kde/workspace/plasma-vault/metadata.yaml [from: projects/kdereview/plasma-vault/metadata.yaml - 084% similarity]

<a href="https://commits.kde.org/sysadmin/repo-metadat" title="https://commits.kde.org/sysadmin/repo-metadat">https://commits.kde.org/sysadmin/repo-metadat</a>

Git commit 43127546b6b0ff52ae098336114e2febe13e3a5e by David Faure.
Committed on 03/01/2017 at 11:37.
Pushed by dfaure into branch 'master'.

KSycoca unittest: reduce the amount of waiting, if Qt >= 5.8 is used.

lastModified() finally returns milliseconds (qtbase commit 494ced1), which
means we don't need to wait a whole second just to detect that a file was
modified.

Not sure about Windows though...
CCMAIL: <a href="mailto:kde- ... at kde dot org">kde- ... at kde dot org</a>

REVIEW: 129734

M +16 -8 autotests/ksycocatest.cpp

<a href="https://commits.kde.org/kservice/43127546b6b0ff52ae098336114e2febe13e3a5e" title="https://commits.kde.org/kservice/43127546b6b0ff52ae098336114e2febe13e3a5e">https://commits.kde.org/kservice/43127546b6b0ff52ae098336114e2febe13e3a5e</a>

diff --git a/autotests/ksycocate

See <http://build.kde.org/job/kde-runtime_stable/637/changes>

See <http://build.kde.org/job/kde-runtime_stable/606/>

See <http://build.kde.org/job/kde-runtime_stable/600/changes>

See <http://build.kde.org/job/kde-runtime_stable/598/changes>

Status
This change has been marked as submitted.

Review request for KDE Runtime, David Faure and Tobias Koenig.

Description
The attached patch fixes a bug where deleting a symlink to a very large file causes a "trash has reached its limit error.

This review has been submitted with commit 4e04319afc77bfb66287439386b705e7c3e5ae54 by Dawit Alemayehu to branch KDE/4.11.

- Commit Hook

On Aug. 21, 2013, 5:20 a.m., Dawit Alemayehu wrote: